ensure that generated validators are up to date

[Uzlopak]

With this PR we ensure that we keep our generated code up date

Checklist

• run npm run test and npm run benchmark
• tests and/or benchmarks are included
• documentation is changed or added
• commit message and code follows the Developer's Certification of Origin
  and the Code of conduct

[climba03003]

LGTM.
I hope there would be a Github Action that can be schedule run and take care of it.

[Uzlopak]

hmm. strange. it fails

name: ci

on:
  schedule:
    - cron: 0 8 * * *
  workflow_dispatch:

jobs:
  build-integrity:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v3
        id: checkout

      - name: Use Node.js
        id: setup-node
        uses: actions/setup-node@v3
        with:
          node-version: "lts/*"

      - name: Install
        id: install
        run: |
          npm install --ignore-scripts
      
      - name: Check Integrity
        id: check
        continue-on-error: true
        run: |
          npm run test:validator:integrity

      - name: Create branch if necessary
        run: |
          git config user.name 'github-actions[bot]'
          git config user.email 'github-actions[bot]@users.noreply.github.com'
          git checkout -b rebuild-validators
          git add . &&
          git commit -m "Rebuild Validators"
          git push origin HEAD:rebuild-validators

      - name: Create PR if necessary
        if: steps.check.outcome != 'success'
        uses: octokit/request-action@v2.x
        with:
          route: POST /repos/{owner}/{repo}/pulls
          owner: fastify
          repo: fastify
          base: main
          head: rebuild-validators
          title: Rebuilt Validators
          body: The generated validators are rebuilt.
        env:
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

[mcollina]

lgtm

[mcollina]

CI seems failing

[jsumners]

If we are going to disable the linter, it would be better to include the rule it is disabling, e.g. // eslint-disable some-rule. However, I have a bigger issue than that:

What does this regular expression do? There needs to at least be a jsdoc block describing the purpose of this regular expression and each component of it. I can't even begin to tell you what this does by just looking at it. It'll be completely impossible to decipher is 2 weeks, much less in 2 years.

Personally, I think that if we are going to start adding so many indecipherable regular expressions to the code then we should start using xregexp to help make them legible.

[Eomm]

This is a generated file, so we rely on ajv here

If the comment has been added manually, it could be the cause for the failing CI - we need to add the generated files to the eslint ignore list

[climba03003]

lib/error-serializer.js is a auto-generated file. We should not expect any manual change here.
Any changes should made on https://github.com/fastify/fast-json-stringify

I dislike generated code.

[mcollina]

There seem to be a problem on Windows.

[mcollina]

lgtm

[mcollina]

I would actually move this check to the pre-publish stage and not run it on CI.

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.