Maintain custom response schema

[jaschaephraim]

If a schema has a custom prototype (like when using a Zod schema), normalization will be skipped. Currently this does not work in the case where there are only response schemas.

This PR accounts for that case and adds a test.

Checklist

• run npm run test and npm run benchmark
• tests and/or benchmarks are included
• documentation is changed or added
• commit message and code follows the Developer's Certification of Origin
  and the Code of conduct

[Eomm]

we can't use in as it loops the prototype too.
We must list all the keys we are looking for

[Eomm]

as above: no in

Suggested change

	for (const statusCode in routeSchemas.response) {
	for (const statusCode of Object.keys(routeSchemas.response)) {

[Eomm]

We can't check the response like this.

This won't work if the user sets a json schema as header and a custom response schema: in this case the header schema will not be processed because the response check will be true and it will bypass all the following logic.

It is necessary to run this check with another implementation

[jaschaephraim]

Hey @Eomm thanks for the feedback. This seems to be how it currently works: if any one schema is a custom class then the whole normalization is skipped. I can address that and add additional test cases if that's not the intended behavior.

[Eomm]

Yeah, for sure, it needs some refactoring.

We can sum up these cases:

input	output
json schema or empty checked	json schema checked
custom class checked	json schema checked
json schema or empty checked	custom class processed 🐛
custom class checked	custom class skipped 🐛

We need to fix only the two 🐛 cases without introducing other breaking 👍🏼

[jaschaephraim]

Per the suggestion from @Eomm I've updated the PR to handle an underlying issue and added test cases.

Previously if any individual schema was an instance of a custom class then normalization would be skipped for all the route's schemas. Now they're checked and handled individually.

[mcollina]

lgtm

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.