Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: post async regression with empty body #5008

Merged
merged 4 commits into from Aug 31, 2023
Merged

fix: post async regression with empty body #5008

merged 4 commits into from Aug 31, 2023

Conversation

mcollina
Copy link
Member

This PR reverts #4963 and adds a test to prevent such regressions.

Checklist

@mcollina
Revert "Do not double send the response if the request is destroyed b…
259d2e5 
…ut not aborted (#4963)"

This reverts commit c235d2d.
@mcollina
Fix support for empty POST responses
baff82d 
Signed-off-by: Matteo Collina <hello@matteocollina.com>
@mcollina mcollina changed the title Fix post async regression Fix post async regression with empty body Aug 31, 2023
@mcollina mcollina changed the title Fix post async regression with empty body fix: post async regression with empty body Aug 31, 2023
@mcollina mcollina mentioned this pull request Aug 31, 2023
Open
2 tasks
@climba03003
Copy link
Member

So, it must be checking the reply.raw.socket.destroyed instead of reply.request.raw.destoryed.
Losting duplex socket means the underlaying resources is closed in unexpected way.

@mcollina
Copy link
Member Author

Can somebody push a fix for the test? I’m currently on vacation and this needs to be fixed asap.

@climba03003
Copy link
Member

I didn't spot any particular error inside the ci log. Strange.

@mcollina
fixup
7349443 
Signed-off-by: Matteo Collina <hello@matteocollina.com>
@mcollina
fixup
675a9de 
Signed-off-by: Matteo Collina <hello@matteocollina.com>
@mcollina mcollina merged commit 498b17c into main Aug 31, 2023
28 checks passed
@mcollina mcollina deleted the fix-post-async-bug branch August 31, 2023 18:12
renovate bot added a commit to tomacheese/telcheck that referenced this pull request Aug 31, 2023
@renovate
chore(deps): update dependency fastify to v4.22.1 (#268)
0961fba 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [fastify](https://www.fastify.io/)
([source](https://togithub.com/fastify/fastify)) | [`4.22.0` ->
`4.22.1`](https://renovatebot.com/diffs/npm/fastify/4.22.0/4.22.1) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/fastify/4.22.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/fastify/4.22.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/fastify/4.22.0/4.22.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/fastify/4.22.0/4.22.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>fastify/fastify (fastify)</summary>

###
[`v4.22.1`](https://togithub.com/fastify/fastify/releases/tag/v4.22.1)

[Compare
Source](https://togithub.com/fastify/fastify/compare/v4.22.0...v4.22.1)

#### What's Changed

- chore: Bump the dev-dependencies group with 1 update by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[fastify/fastify#5002
- docs(ecosystem): add fastify-rabbitmq to ecosystem.md by
[@&#8203;Bugs5382](https://togithub.com/Bugs5382) in
[fastify/fastify#5000
- docs(ecosystem): add `@fastify/throttle` to core list by
[@&#8203;Fdawgs](https://togithub.com/Fdawgs) in
[fastify/fastify#5004
- fix: typos by [@&#8203;Uzlopak](https://togithub.com/Uzlopak) in
[fastify/fastify#5006
- docs: typo on catch statement inside Postgrator migration example by
[@&#8203;alessandrob88](https://togithub.com/alessandrob88) in
[fastify/fastify#5007
- fix: post async regression with empty body by
[@&#8203;mcollina](https://togithub.com/mcollina) in
[fastify/fastify#5008

#### New Contributors

- [@&#8203;Bugs5382](https://togithub.com/Bugs5382) made their first
contribution in
[fastify/fastify#5000
- [@&#8203;alessandrob88](https://togithub.com/alessandrob88) made their
first contribution in
[fastify/fastify#5007

**Full Changelog**:
fastify/fastify@v4.22.0...v4.22.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/tomacheese/telcheck).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi42OC4xIiwidXBkYXRlZEluVmVyIjoiMzYuNjguMSIsInRhcmdldEJyYW5jaCI6Im1hc3RlciJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
thedavidprice added a commit to redwoodjs/redwood that referenced this pull request Sep 8, 2023
@renovate @thedavidprice
fix(deps): update dependency fastify to v4.22.2 (#9124)
c01ae41 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [fastify](https://www.fastify.io/)
([source](https://togithub.com/fastify/fastify)) | [`4.22.0` ->
`4.22.2`](https://renovatebot.com/diffs/npm/fastify/4.22.0/4.22.2) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/fastify/4.22.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/fastify/4.22.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/fastify/4.22.0/4.22.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/fastify/4.22.0/4.22.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>fastify/fastify (fastify)</summary>

###
[`v4.22.2`](https://togithub.com/fastify/fastify/releases/tag/v4.22.2)

[Compare
Source](https://togithub.com/fastify/fastify/compare/v4.22.1...v4.22.2)

A spurious file (a test run result) was added to the package, which was
now removed.

###
[`v4.22.1`](https://togithub.com/fastify/fastify/releases/tag/v4.22.1)

[Compare
Source](https://togithub.com/fastify/fastify/compare/v4.22.0...v4.22.1)

#### What's Changed

- chore: Bump the dev-dependencies group with 1 update by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[fastify/fastify#5002
- docs(ecosystem): add fastify-rabbitmq to ecosystem.md by
[@&#8203;Bugs5382](https://togithub.com/Bugs5382) in
[fastify/fastify#5000
- docs(ecosystem): add `@fastify/throttle` to core list by
[@&#8203;Fdawgs](https://togithub.com/Fdawgs) in
[fastify/fastify#5004
- fix: typos by [@&#8203;Uzlopak](https://togithub.com/Uzlopak) in
[fastify/fastify#5006
- docs: typo on catch statement inside Postgrator migration example by
[@&#8203;alessandrob88](https://togithub.com/alessandrob88) in
[fastify/fastify#5007
- fix: post async regression with empty body by
[@&#8203;mcollina](https://togithub.com/mcollina) in
[fastify/fastify#5008

#### New Contributors

- [@&#8203;Bugs5382](https://togithub.com/Bugs5382) made their first
contribution in
[fastify/fastify#5000
- [@&#8203;alessandrob88](https://togithub.com/alessandrob88) made their
first contribution in
[fastify/fastify#5007

**Full Changelog**:
fastify/fastify@v4.22.0...v4.22.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/redwoodjs/redwood).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi42OC4xIiwidXBkYXRlZEluVmVyIjoiMzYuNjguMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: David Price <thedavid@thedavidprice.com>
jtoar pushed a commit to redwoodjs/redwood that referenced this pull request Sep 13, 2023
@renovate @thedavidprice @jtoar
fix(deps): update dependency fastify to v4.22.2 (#9124)
59f3c6f 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [fastify](https://www.fastify.io/)
([source](https://togithub.com/fastify/fastify)) | [`4.22.0` ->
`4.22.2`](https://renovatebot.com/diffs/npm/fastify/4.22.0/4.22.2) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/fastify/4.22.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/fastify/4.22.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/fastify/4.22.0/4.22.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/fastify/4.22.0/4.22.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>fastify/fastify (fastify)</summary>

###
[`v4.22.2`](https://togithub.com/fastify/fastify/releases/tag/v4.22.2)

[Compare
Source](https://togithub.com/fastify/fastify/compare/v4.22.1...v4.22.2)

A spurious file (a test run result) was added to the package, which was
now removed.

###
[`v4.22.1`](https://togithub.com/fastify/fastify/releases/tag/v4.22.1)

[Compare
Source](https://togithub.com/fastify/fastify/compare/v4.22.0...v4.22.1)

#### What's Changed

- chore: Bump the dev-dependencies group with 1 update by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[fastify/fastify#5002
- docs(ecosystem): add fastify-rabbitmq to ecosystem.md by
[@&#8203;Bugs5382](https://togithub.com/Bugs5382) in
[fastify/fastify#5000
- docs(ecosystem): add `@fastify/throttle` to core list by
[@&#8203;Fdawgs](https://togithub.com/Fdawgs) in
[fastify/fastify#5004
- fix: typos by [@&#8203;Uzlopak](https://togithub.com/Uzlopak) in
[fastify/fastify#5006
- docs: typo on catch statement inside Postgrator migration example by
[@&#8203;alessandrob88](https://togithub.com/alessandrob88) in
[fastify/fastify#5007
- fix: post async regression with empty body by
[@&#8203;mcollina](https://togithub.com/mcollina) in
[fastify/fastify#5008

#### New Contributors

- [@&#8203;Bugs5382](https://togithub.com/Bugs5382) made their first
contribution in
[fastify/fastify#5000
- [@&#8203;alessandrob88](https://togithub.com/alessandrob88) made their
first contribution in
[fastify/fastify#5007

**Full Changelog**:
fastify/fastify@v4.22.0...v4.22.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/redwoodjs/redwood).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi42OC4xIiwidXBkYXRlZEluVmVyIjoiMzYuNjguMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: David Price <thedavid@thedavidprice.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@climba03003 climba03003 climba03003 approved these changes

@Uzlopak Uzlopak Awaiting requested review from Uzlopak

@Eomm Eomm Awaiting requested review from Eomm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mcollina @climba03003