Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix broken ci by skipping tests if node v > 18.19.0 #5195

Merged
merged 3 commits into from Dec 10, 2023
Merged

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Dec 8, 2023

I guess in 18.19.0 the PR which has something to do with closeIdleConnections got backported and thus breaking our CI.

Checklist

@github-actions github-actions bot added the test Issue or pr related to our testing infrastructure. label Dec 8, 2023
@jsumners
Copy link
Member

jsumners commented Dec 8, 2023

I think there is something broken in 18.19.0. I have been trying to determine a problem at work around this. The only difference is the runtime changing from 18.18.2 to 18.19.0:

I'd rather we pin to 18.18.2 until we can determine the issue and hopefully get an 18.19.1. That, or make the exclusion check for === 18.19.0.

@jsumners
Copy link
Member

jsumners commented Dec 8, 2023

FYI: this has shown up in today's CI because of actions/runner-images@e11b878

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Dec 8, 2023

Can you please take this task over? I will not at my PC for the next few hours.

@Uzlopak Uzlopak mentioned this pull request Dec 8, 2023
4 tasks
@Uzlopak Uzlopak closed this Dec 8, 2023
@Uzlopak Uzlopak deleted the fix-ci-cd branch December 8, 2023 19:27
@Uzlopak Uzlopak restored the fix-ci-cd branch December 10, 2023 03:40
@Uzlopak Uzlopak reopened this Dec 10, 2023
@Uzlopak Uzlopak linked an issue Dec 10, 2023 that may be closed by this pull request
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit e9764f3 into main Dec 10, 2023
28 checks passed
@mcollina mcollina deleted the fix-ci-cd branch December 10, 2023 10:28
renovate bot added a commit to tomacheese/telcheck that referenced this pull request Dec 13, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [fastify](https://www.fastify.dev/)
([source](https://togithub.com/fastify/fastify)) | [`4.24.3` ->
`4.25.0`](https://renovatebot.com/diffs/npm/fastify/4.24.3/4.25.0) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/fastify/4.25.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/fastify/4.25.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/fastify/4.24.3/4.25.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/fastify/4.24.3/4.25.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>fastify/fastify (fastify)</summary>

###
[`v4.25.0`](https://togithub.com/fastify/fastify/releases/tag/v4.25.0)

[Compare
Source](https://togithub.com/fastify/fastify/compare/v4.24.3...v4.25.0)

#### What's Changed

- feat: Improve RouteShorthandOptions\['constraints'] type by
[@&#8203;Fcmam5](https://togithub.com/Fcmam5) in
[fastify/fastify#5097
- fix: add [@&#8203;eomm](https://togithub.com/eomm) and
[@&#8203;jsumners](https://togithub.com/jsumners) as lead maintainers by
[@&#8203;mcollina](https://togithub.com/mcollina) in
[fastify/fastify#5115
- fix: reply.send supports Uint8Array payload by
[@&#8203;SgtPooki](https://togithub.com/SgtPooki) in
[fastify/fastify#5124
- refactor: migrate deprecation warnings to actual deprecation warnings
by [@&#8203;jsumners](https://togithub.com/jsumners) in
[fastify/fastify#5126
- docs: added documentation about warnings by
[@&#8203;giuliowaitforitdavide](https://togithub.com/giuliowaitforitdavide)
in
[fastify/fastify#5108
- test(logger): restrict temp file permissions by
[@&#8203;Fdawgs](https://togithub.com/Fdawgs) in
[fastify/fastify#5128
- refactor(lib/hooks): replace `typeof` undefined check by
[@&#8203;Fdawgs](https://togithub.com/Fdawgs) in
[fastify/fastify#5127
- chore: replace mention of fastify `.io` domain with `.dev` by
[@&#8203;Fdawgs](https://togithub.com/Fdawgs) in
[fastify/fastify#5129
- docs(security): add prose explaining OpenSSF CII Best Practices badge
results by [@&#8203;ljharb](https://togithub.com/ljharb) in
[fastify/fastify#5111
- chore: Bump actions/setup-node from 3 to 4 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[fastify/fastify#5134
- fix(types): add handler property to routeOptions by
[@&#8203;MikeJeffers](https://togithub.com/MikeJeffers) in
[fastify/fastify#5136
- docs(readme): fix ci badge path by
[@&#8203;Fdawgs](https://togithub.com/Fdawgs) in
[fastify/fastify#5138
- docs: Fix small typo in Typescript docs by
[@&#8203;john-ko](https://togithub.com/john-ko) in
[fastify/fastify#5145
- feat(plugins): mixing async and callback style now returns a warning
by
[@&#8203;giuliowaitforitdavide](https://togithub.com/giuliowaitforitdavide)
in
[fastify/fastify#5139
- docs: mention about multipart support by
[@&#8203;fawazahmed0](https://togithub.com/fawazahmed0) in
[fastify/fastify#5144
- docs: add [@&#8203;fastify/vite](https://togithub.com/fastify/vite) to
core plugins list by [@&#8203;galvez](https://togithub.com/galvez) in
[fastify/fastify#5153
- docs: add
[@&#8203;scalar/fastify-api-reference](https://togithub.com/scalar/fastify-api-reference)
to community plugins list by
[@&#8203;hanspagel](https://togithub.com/hanspagel) in
[fastify/fastify#5154
- docs: Remove routeOptions reference in Reply.md by
[@&#8203;shadahmad7](https://togithub.com/shadahmad7) in
[fastify/fastify#5156
- docs(ecosystem): add fastify-uws by
[@&#8203;tinchoz49](https://togithub.com/tinchoz49) in
[fastify/fastify#5160
- docs: removed unmaintained fastify-nodemailer from ecosystem by
[@&#8203;giovanni-bertoncelli](https://togithub.com/giovanni-bertoncelli)
in
[fastify/fastify#5161
- docs: clarify handling of streams and buffers by
[@&#8203;brettwillis](https://togithub.com/brettwillis) in
[fastify/fastify#5166
-
docs([#&#8203;5142](https://togithub.com/fastify/fastify/issues/5142)):
aligned errors and warnings documentation by
[@&#8203;giuliowaitforitdavide](https://togithub.com/giuliowaitforitdavide)
in
[fastify/fastify#5162
- docs(reference/hooks): add information about prehandler by
[@&#8203;RjManhas](https://togithub.com/RjManhas) in
[fastify/fastify#5163
- fix: type FastifyInstance\['route'] and RouteShorthandMethod by
[@&#8203;MunifTanjim](https://togithub.com/MunifTanjim) in
[fastify/fastify#5155
- docs (reference): Fix small typo in Request by
[@&#8203;bngarren](https://togithub.com/bngarren) in
[fastify/fastify#5186
- chore: gitpodify by
[@&#8203;ghostdevv](https://togithub.com/ghostdevv) in
[fastify/fastify#5168
- docs(ecosystem): Add Apitally by
[@&#8203;itssimon](https://togithub.com/itssimon) in
[fastify/fastify#5175
- fix: Update reply.context deprecation warning by
[@&#8203;avaly](https://togithub.com/avaly) in
[fastify/fastify#5179
- docs(ecosystem): adds @&#8203;blastorg/fastify/aws-dynamodb-cache to
community plugins list by
[@&#8203;fredrikj31](https://togithub.com/fredrikj31) in
[fastify/fastify#5158
- docs: update preHandler hook example by
[@&#8203;tarunrajput](https://togithub.com/tarunrajput) in
[fastify/fastify#5189
- types: added http header types to reply by
[@&#8203;skwee357](https://togithub.com/skwee357) in
[fastify/fastify#5046
- test: add tests for TOC of errors.md by
[@&#8203;Uzlopak](https://togithub.com/Uzlopak) in
[fastify/fastify#5194
- ci: pin node 18 to 18.18.2 by
[@&#8203;Uzlopak](https://togithub.com/Uzlopak) in
[fastify/fastify#5197
- docs(ecosystem): add http-wizard by
[@&#8203;flodlc](https://togithub.com/flodlc) in
[fastify/fastify#5132
- chore: Bump actions/github-script from 6 to 7 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[fastify/fastify#5183
- ci: fix broken ci by skipping tests if node v > 18.19.0 by
[@&#8203;Uzlopak](https://togithub.com/Uzlopak) in
[fastify/fastify#5195
- fix: allow async hooks in `RouteShorthandOptions` without breaking
`request` and `reply` types by
[@&#8203;bienzaaron](https://togithub.com/bienzaaron) in
[fastify/fastify#5147
- fix([#&#8203;5180](https://togithub.com/fastify/fastify/issues/5180)):
close secondary bindings after primary is closed by
[@&#8203;metcoder95](https://togithub.com/metcoder95) in
[fastify/fastify#5201
- chore: update process-warning by
[@&#8203;Eomm](https://togithub.com/Eomm) in
[fastify/fastify#5206
- types: nullish error types in callback function's parameter for
`after` and `ready` method by
[@&#8203;nokazn](https://togithub.com/nokazn) in
[fastify/fastify#5191
- fix([#&#8203;5049](https://togithub.com/fastify/fastify/issues/5049)):
Remove duplicated calls to onReady by
[@&#8203;metcoder95](https://togithub.com/metcoder95) in
[fastify/fastify#5051
- chore: remove unused type assertion by
[@&#8203;UndefinedBehaviour](https://togithub.com/UndefinedBehaviour) in
[fastify/fastify#5184

#### New Contributors

- [@&#8203;Fcmam5](https://togithub.com/Fcmam5) made their first
contribution in
[fastify/fastify#5097
- [@&#8203;SgtPooki](https://togithub.com/SgtPooki) made their first
contribution in
[fastify/fastify#5124
- [@&#8203;MikeJeffers](https://togithub.com/MikeJeffers) made their
first contribution in
[fastify/fastify#5136
- [@&#8203;john-ko](https://togithub.com/john-ko) made their first
contribution in
[fastify/fastify#5145
- [@&#8203;fawazahmed0](https://togithub.com/fawazahmed0) made their
first contribution in
[fastify/fastify#5144
- [@&#8203;hanspagel](https://togithub.com/hanspagel) made their first
contribution in
[fastify/fastify#5154
- [@&#8203;shadahmad7](https://togithub.com/shadahmad7) made their first
contribution in
[fastify/fastify#5156
-
[@&#8203;giovanni-bertoncelli](https://togithub.com/giovanni-bertoncelli)
made their first contribution in
[fastify/fastify#5161
- [@&#8203;RjManhas](https://togithub.com/RjManhas) made their first
contribution in
[fastify/fastify#5163
- [@&#8203;MunifTanjim](https://togithub.com/MunifTanjim) made their
first contribution in
[fastify/fastify#5155
- [@&#8203;bngarren](https://togithub.com/bngarren) made their first
contribution in
[fastify/fastify#5186
- [@&#8203;ghostdevv](https://togithub.com/ghostdevv) made their first
contribution in
[fastify/fastify#5168
- [@&#8203;itssimon](https://togithub.com/itssimon) made their first
contribution in
[fastify/fastify#5175
- [@&#8203;avaly](https://togithub.com/avaly) made their first
contribution in
[fastify/fastify#5179
- [@&#8203;fredrikj31](https://togithub.com/fredrikj31) made their first
contribution in
[fastify/fastify#5158
- [@&#8203;tarunrajput](https://togithub.com/tarunrajput) made their
first contribution in
[fastify/fastify#5189
- [@&#8203;skwee357](https://togithub.com/skwee357) made their first
contribution in
[fastify/fastify#5046
- [@&#8203;flodlc](https://togithub.com/flodlc) made their first
contribution in
[fastify/fastify#5132
- [@&#8203;nokazn](https://togithub.com/nokazn) made their first
contribution in
[fastify/fastify#5191
- [@&#8203;UndefinedBehaviour](https://togithub.com/UndefinedBehaviour)
made their first contribution in
[fastify/fastify#5184

**Full Changelog**:
fastify/fastify@v4.24.3...v4.25.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/tomacheese/telcheck).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy44Ny4yIiwidXBkYXRlZEluVmVyIjoiMzcuODcuMiIsInRhcmdldEJyYW5jaCI6Im1hc3RlciJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate bot added a commit to redwoodjs/redwood that referenced this pull request Jan 29, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [fastify](https://www.fastify.dev/)
([source](https://togithub.com/fastify/fastify)) | [`4.24.3` ->
`4.25.2`](https://renovatebot.com/diffs/npm/fastify/4.24.3/4.25.2) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/fastify/4.25.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/fastify/4.25.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/fastify/4.24.3/4.25.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/fastify/4.24.3/4.25.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>fastify/fastify (fastify)</summary>

###
[`v4.25.2`](https://togithub.com/fastify/fastify/releases/tag/v4.25.2)

[Compare
Source](https://togithub.com/fastify/fastify/compare/v4.25.1...v4.25.2)

#### What's Changed

- fix: `npm run test:watch` by
[@&#8203;domdomegg](https://togithub.com/domdomegg) in
[fastify/fastify#5221
- fix: always consume stream payloads when responding to 204 with no
body by [@&#8203;mcollina](https://togithub.com/mcollina) in
[fastify/fastify#5231
- docs: update setErrorHandler to explain not found behaviour by
[@&#8203;domdomegg](https://togithub.com/domdomegg) in
[fastify/fastify#5218

#### New Contributors

- [@&#8203;domdomegg](https://togithub.com/domdomegg) made their first
contribution in
[fastify/fastify#5221

**Full Changelog**:
fastify/fastify@v4.25.1...v4.25.2

###
[`v4.25.1`](https://togithub.com/fastify/fastify/releases/tag/v4.25.1)

[Compare
Source](https://togithub.com/fastify/fastify/compare/v4.25.0...v4.25.1)

#### What's Changed

- fix: route constraints by
[@&#8203;climba03003](https://togithub.com/climba03003) in
[fastify/fastify#5207
- fix: Better plugin name detection for FSTWRN002 by
[@&#8203;mcollina](https://togithub.com/mcollina) in
[fastify/fastify#5209
- chore: at-large project by [@&#8203;Eomm](https://togithub.com/Eomm)
in
[fastify/fastify#5211

**Full Changelog**:
fastify/fastify@v4.25.0...v4.25.1

###
[`v4.25.0`](https://togithub.com/fastify/fastify/releases/tag/v4.25.0)

[Compare
Source](https://togithub.com/fastify/fastify/compare/v4.24.3...v4.25.0)

#### What's Changed

- feat: Improve RouteShorthandOptions\['constraints'] type by
[@&#8203;Fcmam5](https://togithub.com/Fcmam5) in
[fastify/fastify#5097
- fix: add [@&#8203;eomm](https://togithub.com/eomm) and
[@&#8203;jsumners](https://togithub.com/jsumners) as lead maintainers by
[@&#8203;mcollina](https://togithub.com/mcollina) in
[fastify/fastify#5115
- fix: reply.send supports Uint8Array payload by
[@&#8203;SgtPooki](https://togithub.com/SgtPooki) in
[fastify/fastify#5124
- refactor: migrate deprecation warnings to actual deprecation warnings
by [@&#8203;jsumners](https://togithub.com/jsumners) in
[fastify/fastify#5126
- docs: added documentation about warnings by
[@&#8203;giuliowaitforitdavide](https://togithub.com/giuliowaitforitdavide)
in
[fastify/fastify#5108
- test(logger): restrict temp file permissions by
[@&#8203;Fdawgs](https://togithub.com/Fdawgs) in
[fastify/fastify#5128
- refactor(lib/hooks): replace `typeof` undefined check by
[@&#8203;Fdawgs](https://togithub.com/Fdawgs) in
[fastify/fastify#5127
- chore: replace mention of fastify `.io` domain with `.dev` by
[@&#8203;Fdawgs](https://togithub.com/Fdawgs) in
[fastify/fastify#5129
- docs(security): add prose explaining OpenSSF CII Best Practices badge
results by [@&#8203;ljharb](https://togithub.com/ljharb) in
[fastify/fastify#5111
- chore: Bump actions/setup-node from 3 to 4 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[fastify/fastify#5134
- fix(types): add handler property to routeOptions by
[@&#8203;MikeJeffers](https://togithub.com/MikeJeffers) in
[fastify/fastify#5136
- docs(readme): fix ci badge path by
[@&#8203;Fdawgs](https://togithub.com/Fdawgs) in
[fastify/fastify#5138
- docs: Fix small typo in Typescript docs by
[@&#8203;john-ko](https://togithub.com/john-ko) in
[fastify/fastify#5145
- feat(plugins): mixing async and callback style now returns a warning
by
[@&#8203;giuliowaitforitdavide](https://togithub.com/giuliowaitforitdavide)
in
[fastify/fastify#5139
- docs: mention about multipart support by
[@&#8203;fawazahmed0](https://togithub.com/fawazahmed0) in
[fastify/fastify#5144
- docs: add [@&#8203;fastify/vite](https://togithub.com/fastify/vite) to
core plugins list by [@&#8203;galvez](https://togithub.com/galvez) in
[fastify/fastify#5153
- docs: add
[@&#8203;scalar/fastify-api-reference](https://togithub.com/scalar/fastify-api-reference)
to community plugins list by
[@&#8203;hanspagel](https://togithub.com/hanspagel) in
[fastify/fastify#5154
- docs: Remove routeOptions reference in Reply.md by
[@&#8203;shadahmad7](https://togithub.com/shadahmad7) in
[fastify/fastify#5156
- docs(ecosystem): add fastify-uws by
[@&#8203;tinchoz49](https://togithub.com/tinchoz49) in
[fastify/fastify#5160
- docs: removed unmaintained fastify-nodemailer from ecosystem by
[@&#8203;giovanni-bertoncelli](https://togithub.com/giovanni-bertoncelli)
in
[fastify/fastify#5161
- docs: clarify handling of streams and buffers by
[@&#8203;brettwillis](https://togithub.com/brettwillis) in
[fastify/fastify#5166
-
docs([#&#8203;5142](https://togithub.com/fastify/fastify/issues/5142)):
aligned errors and warnings documentation by
[@&#8203;giuliowaitforitdavide](https://togithub.com/giuliowaitforitdavide)
in
[fastify/fastify#5162
- docs(reference/hooks): add information about prehandler by
[@&#8203;RjManhas](https://togithub.com/RjManhas) in
[fastify/fastify#5163
- fix: type FastifyInstance\['route'] and RouteShorthandMethod by
[@&#8203;MunifTanjim](https://togithub.com/MunifTanjim) in
[fastify/fastify#5155
- docs (reference): Fix small typo in Request by
[@&#8203;bngarren](https://togithub.com/bngarren) in
[fastify/fastify#5186
- chore: gitpodify by
[@&#8203;ghostdevv](https://togithub.com/ghostdevv) in
[fastify/fastify#5168
- docs(ecosystem): Add Apitally by
[@&#8203;itssimon](https://togithub.com/itssimon) in
[fastify/fastify#5175
- fix: Update reply.context deprecation warning by
[@&#8203;avaly](https://togithub.com/avaly) in
[fastify/fastify#5179
- docs(ecosystem): adds @&#8203;blastorg/fastify/aws-dynamodb-cache to
community plugins list by
[@&#8203;fredrikj31](https://togithub.com/fredrikj31) in
[fastify/fastify#5158
- docs: update preHandler hook example by
[@&#8203;tarunrajput](https://togithub.com/tarunrajput) in
[fastify/fastify#5189
- types: added http header types to reply by
[@&#8203;skwee357](https://togithub.com/skwee357) in
[fastify/fastify#5046
- test: add tests for TOC of errors.md by
[@&#8203;Uzlopak](https://togithub.com/Uzlopak) in
[fastify/fastify#5194
- ci: pin node 18 to 18.18.2 by
[@&#8203;Uzlopak](https://togithub.com/Uzlopak) in
[fastify/fastify#5197
- docs(ecosystem): add http-wizard by
[@&#8203;flodlc](https://togithub.com/flodlc) in
[fastify/fastify#5132
- chore: Bump actions/github-script from 6 to 7 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[fastify/fastify#5183
- ci: fix broken ci by skipping tests if node v > 18.19.0 by
[@&#8203;Uzlopak](https://togithub.com/Uzlopak) in
[fastify/fastify#5195
- fix: allow async hooks in `RouteShorthandOptions` without breaking
`request` and `reply` types by
[@&#8203;bienzaaron](https://togithub.com/bienzaaron) in
[fastify/fastify#5147
- fix([#&#8203;5180](https://togithub.com/fastify/fastify/issues/5180)):
close secondary bindings after primary is closed by
[@&#8203;metcoder95](https://togithub.com/metcoder95) in
[fastify/fastify#5201
- chore: update process-warning by
[@&#8203;Eomm](https://togithub.com/Eomm) in
[fastify/fastify#5206
- types: nullish error types in callback function's parameter for
`after` and `ready` method by
[@&#8203;nokazn](https://togithub.com/nokazn) in
[fastify/fastify#5191
- fix([#&#8203;5049](https://togithub.com/fastify/fastify/issues/5049)):
Remove duplicated calls to onReady by
[@&#8203;metcoder95](https://togithub.com/metcoder95) in
[fastify/fastify#5051
- chore: remove unused type assertion by
[@&#8203;UndefinedBehaviour](https://togithub.com/UndefinedBehaviour) in
[fastify/fastify#5184

#### New Contributors

- [@&#8203;Fcmam5](https://togithub.com/Fcmam5) made their first
contribution in
[fastify/fastify#5097
- [@&#8203;SgtPooki](https://togithub.com/SgtPooki) made their first
contribution in
[fastify/fastify#5124
- [@&#8203;MikeJeffers](https://togithub.com/MikeJeffers) made their
first contribution in
[fastify/fastify#5136
- [@&#8203;john-ko](https://togithub.com/john-ko) made their first
contribution in
[fastify/fastify#5145
- [@&#8203;fawazahmed0](https://togithub.com/fawazahmed0) made their
first contribution in
[fastify/fastify#5144
- [@&#8203;hanspagel](https://togithub.com/hanspagel) made their first
contribution in
[fastify/fastify#5154
- [@&#8203;shadahmad7](https://togithub.com/shadahmad7) made their first
contribution in
[fastify/fastify#5156
-
[@&#8203;giovanni-bertoncelli](https://togithub.com/giovanni-bertoncelli)
made their first contribution in
[fastify/fastify#5161
- [@&#8203;RjManhas](https://togithub.com/RjManhas) made their first
contribution in
[fastify/fastify#5163
- [@&#8203;MunifTanjim](https://togithub.com/MunifTanjim) made their
first contribution in
[fastify/fastify#5155
- [@&#8203;bngarren](https://togithub.com/bngarren) made their first
contribution in
[fastify/fastify#5186
- [@&#8203;ghostdevv](https://togithub.com/ghostdevv) made their first
contribution in
[fastify/fastify#5168
- [@&#8203;itssimon](https://togithub.com/itssimon) made their first
contribution in
[fastify/fastify#5175
- [@&#8203;avaly](https://togithub.com/avaly) made their first
contribution in
[fastify/fastify#5179
- [@&#8203;fredrikj31](https://togithub.com/fredrikj31) made their first
contribution in
[fastify/fastify#5158
- [@&#8203;tarunrajput](https://togithub.com/tarunrajput) made their
first contribution in
[fastify/fastify#5189
- [@&#8203;skwee357](https://togithub.com/skwee357) made their first
contribution in
[fastify/fastify#5046
- [@&#8203;flodlc](https://togithub.com/flodlc) made their first
contribution in
[fastify/fastify#5132
- [@&#8203;nokazn](https://togithub.com/nokazn) made their first
contribution in
[fastify/fastify#5191
- [@&#8203;UndefinedBehaviour](https://togithub.com/UndefinedBehaviour)
made their first contribution in
[fastify/fastify#5184

**Full Changelog**:
fastify/fastify@v4.24.3...v4.25.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these
updates again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/redwoodjs/redwood).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNTMuMiIsInVwZGF0ZWRJblZlciI6IjM3LjE1My4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
jtoar pushed a commit to redwoodjs/redwood that referenced this pull request Jan 29, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [fastify](https://www.fastify.dev/)
([source](https://togithub.com/fastify/fastify)) | [`4.24.3` ->
`4.25.2`](https://renovatebot.com/diffs/npm/fastify/4.24.3/4.25.2) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/fastify/4.25.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/fastify/4.25.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/fastify/4.24.3/4.25.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/fastify/4.24.3/4.25.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>fastify/fastify (fastify)</summary>

###
[`v4.25.2`](https://togithub.com/fastify/fastify/releases/tag/v4.25.2)

[Compare
Source](https://togithub.com/fastify/fastify/compare/v4.25.1...v4.25.2)

#### What's Changed

- fix: `npm run test:watch` by
[@&#8203;domdomegg](https://togithub.com/domdomegg) in
[fastify/fastify#5221
- fix: always consume stream payloads when responding to 204 with no
body by [@&#8203;mcollina](https://togithub.com/mcollina) in
[fastify/fastify#5231
- docs: update setErrorHandler to explain not found behaviour by
[@&#8203;domdomegg](https://togithub.com/domdomegg) in
[fastify/fastify#5218

#### New Contributors

- [@&#8203;domdomegg](https://togithub.com/domdomegg) made their first
contribution in
[fastify/fastify#5221

**Full Changelog**:
fastify/fastify@v4.25.1...v4.25.2

###
[`v4.25.1`](https://togithub.com/fastify/fastify/releases/tag/v4.25.1)

[Compare
Source](https://togithub.com/fastify/fastify/compare/v4.25.0...v4.25.1)

#### What's Changed

- fix: route constraints by
[@&#8203;climba03003](https://togithub.com/climba03003) in
[fastify/fastify#5207
- fix: Better plugin name detection for FSTWRN002 by
[@&#8203;mcollina](https://togithub.com/mcollina) in
[fastify/fastify#5209
- chore: at-large project by [@&#8203;Eomm](https://togithub.com/Eomm)
in
[fastify/fastify#5211

**Full Changelog**:
fastify/fastify@v4.25.0...v4.25.1

###
[`v4.25.0`](https://togithub.com/fastify/fastify/releases/tag/v4.25.0)

[Compare
Source](https://togithub.com/fastify/fastify/compare/v4.24.3...v4.25.0)

#### What's Changed

- feat: Improve RouteShorthandOptions\['constraints'] type by
[@&#8203;Fcmam5](https://togithub.com/Fcmam5) in
[fastify/fastify#5097
- fix: add [@&#8203;eomm](https://togithub.com/eomm) and
[@&#8203;jsumners](https://togithub.com/jsumners) as lead maintainers by
[@&#8203;mcollina](https://togithub.com/mcollina) in
[fastify/fastify#5115
- fix: reply.send supports Uint8Array payload by
[@&#8203;SgtPooki](https://togithub.com/SgtPooki) in
[fastify/fastify#5124
- refactor: migrate deprecation warnings to actual deprecation warnings
by [@&#8203;jsumners](https://togithub.com/jsumners) in
[fastify/fastify#5126
- docs: added documentation about warnings by
[@&#8203;giuliowaitforitdavide](https://togithub.com/giuliowaitforitdavide)
in
[fastify/fastify#5108
- test(logger): restrict temp file permissions by
[@&#8203;Fdawgs](https://togithub.com/Fdawgs) in
[fastify/fastify#5128
- refactor(lib/hooks): replace `typeof` undefined check by
[@&#8203;Fdawgs](https://togithub.com/Fdawgs) in
[fastify/fastify#5127
- chore: replace mention of fastify `.io` domain with `.dev` by
[@&#8203;Fdawgs](https://togithub.com/Fdawgs) in
[fastify/fastify#5129
- docs(security): add prose explaining OpenSSF CII Best Practices badge
results by [@&#8203;ljharb](https://togithub.com/ljharb) in
[fastify/fastify#5111
- chore: Bump actions/setup-node from 3 to 4 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[fastify/fastify#5134
- fix(types): add handler property to routeOptions by
[@&#8203;MikeJeffers](https://togithub.com/MikeJeffers) in
[fastify/fastify#5136
- docs(readme): fix ci badge path by
[@&#8203;Fdawgs](https://togithub.com/Fdawgs) in
[fastify/fastify#5138
- docs: Fix small typo in Typescript docs by
[@&#8203;john-ko](https://togithub.com/john-ko) in
[fastify/fastify#5145
- feat(plugins): mixing async and callback style now returns a warning
by
[@&#8203;giuliowaitforitdavide](https://togithub.com/giuliowaitforitdavide)
in
[fastify/fastify#5139
- docs: mention about multipart support by
[@&#8203;fawazahmed0](https://togithub.com/fawazahmed0) in
[fastify/fastify#5144
- docs: add [@&#8203;fastify/vite](https://togithub.com/fastify/vite) to
core plugins list by [@&#8203;galvez](https://togithub.com/galvez) in
[fastify/fastify#5153
- docs: add
[@&#8203;scalar/fastify-api-reference](https://togithub.com/scalar/fastify-api-reference)
to community plugins list by
[@&#8203;hanspagel](https://togithub.com/hanspagel) in
[fastify/fastify#5154
- docs: Remove routeOptions reference in Reply.md by
[@&#8203;shadahmad7](https://togithub.com/shadahmad7) in
[fastify/fastify#5156
- docs(ecosystem): add fastify-uws by
[@&#8203;tinchoz49](https://togithub.com/tinchoz49) in
[fastify/fastify#5160
- docs: removed unmaintained fastify-nodemailer from ecosystem by
[@&#8203;giovanni-bertoncelli](https://togithub.com/giovanni-bertoncelli)
in
[fastify/fastify#5161
- docs: clarify handling of streams and buffers by
[@&#8203;brettwillis](https://togithub.com/brettwillis) in
[fastify/fastify#5166
-
docs([#&#8203;5142](https://togithub.com/fastify/fastify/issues/5142)):
aligned errors and warnings documentation by
[@&#8203;giuliowaitforitdavide](https://togithub.com/giuliowaitforitdavide)
in
[fastify/fastify#5162
- docs(reference/hooks): add information about prehandler by
[@&#8203;RjManhas](https://togithub.com/RjManhas) in
[fastify/fastify#5163
- fix: type FastifyInstance\['route'] and RouteShorthandMethod by
[@&#8203;MunifTanjim](https://togithub.com/MunifTanjim) in
[fastify/fastify#5155
- docs (reference): Fix small typo in Request by
[@&#8203;bngarren](https://togithub.com/bngarren) in
[fastify/fastify#5186
- chore: gitpodify by
[@&#8203;ghostdevv](https://togithub.com/ghostdevv) in
[fastify/fastify#5168
- docs(ecosystem): Add Apitally by
[@&#8203;itssimon](https://togithub.com/itssimon) in
[fastify/fastify#5175
- fix: Update reply.context deprecation warning by
[@&#8203;avaly](https://togithub.com/avaly) in
[fastify/fastify#5179
- docs(ecosystem): adds @&#8203;blastorg/fastify/aws-dynamodb-cache to
community plugins list by
[@&#8203;fredrikj31](https://togithub.com/fredrikj31) in
[fastify/fastify#5158
- docs: update preHandler hook example by
[@&#8203;tarunrajput](https://togithub.com/tarunrajput) in
[fastify/fastify#5189
- types: added http header types to reply by
[@&#8203;skwee357](https://togithub.com/skwee357) in
[fastify/fastify#5046
- test: add tests for TOC of errors.md by
[@&#8203;Uzlopak](https://togithub.com/Uzlopak) in
[fastify/fastify#5194
- ci: pin node 18 to 18.18.2 by
[@&#8203;Uzlopak](https://togithub.com/Uzlopak) in
[fastify/fastify#5197
- docs(ecosystem): add http-wizard by
[@&#8203;flodlc](https://togithub.com/flodlc) in
[fastify/fastify#5132
- chore: Bump actions/github-script from 6 to 7 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[fastify/fastify#5183
- ci: fix broken ci by skipping tests if node v > 18.19.0 by
[@&#8203;Uzlopak](https://togithub.com/Uzlopak) in
[fastify/fastify#5195
- fix: allow async hooks in `RouteShorthandOptions` without breaking
`request` and `reply` types by
[@&#8203;bienzaaron](https://togithub.com/bienzaaron) in
[fastify/fastify#5147
- fix([#&#8203;5180](https://togithub.com/fastify/fastify/issues/5180)):
close secondary bindings after primary is closed by
[@&#8203;metcoder95](https://togithub.com/metcoder95) in
[fastify/fastify#5201
- chore: update process-warning by
[@&#8203;Eomm](https://togithub.com/Eomm) in
[fastify/fastify#5206
- types: nullish error types in callback function's parameter for
`after` and `ready` method by
[@&#8203;nokazn](https://togithub.com/nokazn) in
[fastify/fastify#5191
- fix([#&#8203;5049](https://togithub.com/fastify/fastify/issues/5049)):
Remove duplicated calls to onReady by
[@&#8203;metcoder95](https://togithub.com/metcoder95) in
[fastify/fastify#5051
- chore: remove unused type assertion by
[@&#8203;UndefinedBehaviour](https://togithub.com/UndefinedBehaviour) in
[fastify/fastify#5184

#### New Contributors

- [@&#8203;Fcmam5](https://togithub.com/Fcmam5) made their first
contribution in
[fastify/fastify#5097
- [@&#8203;SgtPooki](https://togithub.com/SgtPooki) made their first
contribution in
[fastify/fastify#5124
- [@&#8203;MikeJeffers](https://togithub.com/MikeJeffers) made their
first contribution in
[fastify/fastify#5136
- [@&#8203;john-ko](https://togithub.com/john-ko) made their first
contribution in
[fastify/fastify#5145
- [@&#8203;fawazahmed0](https://togithub.com/fawazahmed0) made their
first contribution in
[fastify/fastify#5144
- [@&#8203;hanspagel](https://togithub.com/hanspagel) made their first
contribution in
[fastify/fastify#5154
- [@&#8203;shadahmad7](https://togithub.com/shadahmad7) made their first
contribution in
[fastify/fastify#5156
-
[@&#8203;giovanni-bertoncelli](https://togithub.com/giovanni-bertoncelli)
made their first contribution in
[fastify/fastify#5161
- [@&#8203;RjManhas](https://togithub.com/RjManhas) made their first
contribution in
[fastify/fastify#5163
- [@&#8203;MunifTanjim](https://togithub.com/MunifTanjim) made their
first contribution in
[fastify/fastify#5155
- [@&#8203;bngarren](https://togithub.com/bngarren) made their first
contribution in
[fastify/fastify#5186
- [@&#8203;ghostdevv](https://togithub.com/ghostdevv) made their first
contribution in
[fastify/fastify#5168
- [@&#8203;itssimon](https://togithub.com/itssimon) made their first
contribution in
[fastify/fastify#5175
- [@&#8203;avaly](https://togithub.com/avaly) made their first
contribution in
[fastify/fastify#5179
- [@&#8203;fredrikj31](https://togithub.com/fredrikj31) made their first
contribution in
[fastify/fastify#5158
- [@&#8203;tarunrajput](https://togithub.com/tarunrajput) made their
first contribution in
[fastify/fastify#5189
- [@&#8203;skwee357](https://togithub.com/skwee357) made their first
contribution in
[fastify/fastify#5046
- [@&#8203;flodlc](https://togithub.com/flodlc) made their first
contribution in
[fastify/fastify#5132
- [@&#8203;nokazn](https://togithub.com/nokazn) made their first
contribution in
[fastify/fastify#5191
- [@&#8203;UndefinedBehaviour](https://togithub.com/UndefinedBehaviour)
made their first contribution in
[fastify/fastify#5184

**Full Changelog**:
fastify/fastify@v4.24.3...v4.25.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these
updates again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/redwoodjs/redwood).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNTMuMiIsInVwZGF0ZWRJblZlciI6IjM3LjE1My4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issue or pr related to our testing infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI failure with v18.19.0
3 participants