Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add log on listen #624

Merged
merged 1 commit into from
Jan 5, 2018
Merged

Add log on listen #624

merged 1 commit into from
Jan 5, 2018

Conversation

allevo
Copy link
Member

@allevo allevo commented Jan 5, 2018

Checklist

  • run npm run test and npm run benchmark
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message and code follows Code of conduct

As suggested in fastify/fastify-cli#27, I make this PR.

No doc changed: it is not needed
No Benchmark added: the changed code is not the hot one

jsumners
jsumners approved these changes Jan 5, 2018
View reviewed changes
Copy link
Member

@jsumners jsumners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

delvedor
delvedor approved these changes Jan 5, 2018
View reviewed changes
Copy link
Member

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@allevo allevo merged commit f5d7210 into fastify:master Jan 5, 2018
@allevo allevo deleted the add-log-on-listen branch January 5, 2018 16:42
@allevo allevo mentioned this pull request Jan 7, 2018
Merged
4 tasks
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2022
@Eomm Eomm added the semver-minor Issue or PR that should land as semver minor label Apr 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jsumners jsumners jsumners approved these changes

@delvedor delvedor delvedor approved these changes

Assignees
No one assigned
Labels
semver-minor Issue or PR that should land as semver minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@allevo @jsumners @delvedor @Eomm