Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't remove forward slashes in regex #122

Merged
merged 1 commit into from
May 3, 2021
Merged

Don't remove forward slashes in regex #122

merged 1 commit into from
May 3, 2021

Conversation

svile
Copy link
Contributor

@svile svile commented Apr 27, 2021

When passing a regex without any flags to string().pattern(regex) all forward slashes within the regex would be removed. This fix removes only forward slashes (with flags if any) from the end of the regex string.

Checklist

Copy link
Member

@climba03003 climba03003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @aboutlo Can you take a look on it?

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@coveralls
Copy link

Pull Request Test Coverage Report for Build 788929602

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.554%

Totals Coverage Status
Change from base Build 788612384: 0.0%
Covered Lines: 408
Relevant Lines: 408

💛 - Coveralls

@coveralls
Copy link

coveralls commented May 2, 2021

Pull Request Test Coverage Report for Build 788929602

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.554%

Totals Coverage Status
Change from base Build 788612384: 0.0%
Covered Lines: 408
Relevant Lines: 408

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants