Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue a v1.0.0 release #43

Closed
2 tasks done
jsumners opened this issue Dec 16, 2021 · 6 comments · Fixed by #45
Closed
2 tasks done

Issue a v1.0.0 release #43

jsumners opened this issue Dec 16, 2021 · 6 comments · Fixed by #45

Comments

@jsumners
Copy link
Member

Prerequisites

  • I have written a descriptive issue title
  • I have searched existing issues to ensure the issue has not already been raised

Issue

pinojs/pino#1269

The time has long passed for a v1.0.0 release. We really shouldn't be shipping major, non-RC, versions of Fastify with 0.y.z dependencies; especially not dependencies we control.

@mcollina
Copy link
Member

I think we should rename this module to something non-fastify related. This is quite useful in a lot of places (including pino) and it sounds weird to use a fastify themed module.

How about: avvertimento (warning in Italian) or "here-be-dragons"?

@jsumners
Copy link
Member Author

I fear neither name would be discoverable. What do you think about process-warning?

@mcollina
Copy link
Member

that's actually a good name. Any objection to rename this module to process-warning? cc @fastify/core

@RafaelGSS
Copy link
Member

Sounds good to me.

@zekth
Copy link
Member

zekth commented Dec 27, 2021

good to me

@delvedor
Copy link
Member

Good for me as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants