Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renamed to process-warning #45

Merged
merged 1 commit into from
Dec 28, 2021
Merged

Renamed to process-warning #45

merged 1 commit into from
Dec 28, 2021

Conversation

mcollina
Copy link
Member

Signed-off-by: Matteo Collina hello@matteocollina.com

Fixes #43

Checklist

@mcollina
Renamed to process-warning
a86e2b7 
Signed-off-by: Matteo Collina <hello@matteocollina.com>
RafaelGSS
RafaelGSS approved these changes Dec 28, 2021
View reviewed changes
Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

zekth
zekth approved these changes Dec 28, 2021
View reviewed changes
Copy link
Member

@zekth zekth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✌️

jsumners
jsumners approved these changes Dec 28, 2021
View reviewed changes
Copy link
Member

@jsumners jsumners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. But technically #43 is not solved until a v1.0.0 is published.

@mcollina
Copy link
Member Author

I'll bump the major and deprecate the previous module once this lands.

@mcollina mcollina merged commit 91a9886 into master Dec 28, 2021
@mcollina mcollina deleted the rename branch December 28, 2021 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fdawgs Fdawgs Fdawgs approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@zekth zekth zekth approved these changes

@jsumners jsumners jsumners approved these changes

@delvedor delvedor Awaiting requested review from delvedor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue a v1.0.0 release
5 participants
@mcollina @jsumners @zekth @RafaelGSS @Fdawgs