refactor: use optional chaining

[Fdawgs]

Now that we are targeting Node 14 and above we can take advantage of optional chaining and cut down the length of the conditions used in if() statements in this repo.

Checklist

• run npm run test and npm run benchmark
• commit message and code follows the Developer's Certification of Origin
  and the Code of conduct

[Fdawgs]

Thanks @Eomm, fixing the shared workflow then will retrigger CI for this.

[mcollina]

lgtm

(be careful that in v14 and possibly in v16 optional chaining is still slower than alternatives)

[Fdawgs]

lgtm

(be careful that in v14 and possibly in v16 optional chaining is still slower than alternatives)

Ah well I learned something new today. Not too sure it's worth doing this then if it affects performance.

[Fdawgs]

@mcollina, as you're heavily involved in Node itself, any suggestions as to where I can learn more about performance differences and optimizations for Node?

[mcollina]

as you're heavily involved in Node itself, any suggestions as to where I can learn more about performance differences and optimizations for Node?

I don't think there is much documentation :(

[Fdawgs]

as you're heavily involved in Node itself, any suggestions as to where I can learn more about performance differences and optimizations for Node?

I don't think there is much documentation :(

Ah okay, no worries, thanks anyway!

[climba03003]

I think it failed because of recent change in @fastify/cookie?
fastify/fastify-cookie@f417694

My fault, it is not related to @fastify/cookie.

[mcollina]

Have you identified the reason @climba03003? Should we revert that change?

[climba03003]

Have you identified the reason @climba03003? Should we revert that change?

After debugging deeper, I spot the error is about the optional chaining.
Some changes is not identical to before.

[climba03003]

CI is green. LGTM.