Skip to content
This repository has been archived by the owner on Jul 8, 2023. It is now read-only.

Fix/broken links #72

Merged
merged 6 commits into from
Jul 10, 2018
Merged

Fix/broken links #72

merged 6 commits into from
Jul 10, 2018

Conversation

lmammino
Copy link
Member

@lmammino lmammino commented Jul 10, 2018

Fixes #71

Changes proposed here closes most of the outstanding broken links. I am trying to figure out the remaining ones!

Remaining:

Found 20 broken links.

http://127.0.0.1:8080/docs/latest/Server-Methods.md
http://127.0.0.1:8080/docs/v0.42.x/Factory.md
http://127.0.0.1:8080/docs/v1.3.x/Factory
http://127.0.0.1:8080/docs/v1.4.x/Factory
http://127.0.0.1:8080/docs/v1.5.x/Factory
http://127.0.0.1:8080/docs/v0.41.x/Factory.md
http://127.0.0.1:8080/docs/v0.40.x/Factory.md
http://127.0.0.1:8080/docs/v1.1.x/Factory
http://127.0.0.1:8080/docs/v1.2.x/Factory
http://127.0.0.1:8080/docs/latest/Factory/Logging.md
http://127.0.0.1:8080/docs/latest/Logging/Factory.md
http://127.0.0.1:8080/docs/latest/Factory.md
http://127.0.0.1:8080/docs/master/Factory.md
http://127.0.0.1:8080/docs/v1.6.x/Factory
http://127.0.0.1:8080/docs/v1.7.x/Factory
http://127.0.0.1:8080/docs/master/Server-Methods.md
http://127.0.0.1:8080/docs/v0.43.x/Factory.md
http://127.0.0.1:8080/docs/master/Factory/Logging.md
http://127.0.0.1:8080/docs/master/Logging/Factory.md
http://127.0.0.1:8080/docs/v1.0.x/Factory

@lmammino lmammino self-assigned this Jul 10, 2018
@lmammino lmammino added the bug Confirmed bug label Jul 10, 2018
@lmammino
Copy link
Member Author

After last commit:

Found 16 broken links.

http://127.0.0.1:8080/docs/v1.3.x/Factory
http://127.0.0.1:8080/docs/v1.4.x/Factory
http://127.0.0.1:8080/docs/v1.5.x/Factory
http://127.0.0.1:8080/docs/v0.41.x/Factory
http://127.0.0.1:8080/docs/v0.40.x/Factory
http://127.0.0.1:8080/docs/v1.1.x/Factory
http://127.0.0.1:8080/docs/v1.2.x/Factory
http://127.0.0.1:8080/docs/latest/Factory/Logging.md
http://127.0.0.1:8080/docs/latest/Logging/Factory.md
http://127.0.0.1:8080/docs/v1.6.x/Factory
http://127.0.0.1:8080/docs/v1.7.x/Factory
http://127.0.0.1:8080/docs/v0.43.x/Factory
http://127.0.0.1:8080/docs/v0.42.x/Factory
http://127.0.0.1:8080/docs/master/Factory/Logging.md
http://127.0.0.1:8080/docs/master/Logging/Factory.md
http://127.0.0.1:8080/docs/v1.0.x/Factory

@lmammino
Copy link
Member Author

After last commit:

Found 4 broken links.

http://127.0.0.1:8080/docs/master/Logging/Factory.md
http://127.0.0.1:8080/docs/latest/Logging/Factory.md
http://127.0.0.1:8080/docs/master/Factory/Logging.md
http://127.0.0.1:8080/docs/latest/Factory/Logging.md

This is mergeable at this point. Those remaining links have to be cleaned up at source. I will submit a separate PR in the main repo in few hours!

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lmammino
Copy link
Member Author

🎉

@lmammino lmammino merged commit fd61f53 into master Jul 10, 2018
@mcollina mcollina deleted the fix/broken-links branch July 10, 2018 17:25
@allevo
Copy link
Member

allevo commented Jul 10, 2018

Great! 👍

@lmammino lmammino mentioned this pull request Jul 10, 2018
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Confirmed bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken links in doc
3 participants