Fix Swift project handling

[lvillani]

Swift project may bundle additional ".framework" bundles, make sure to not search them while looking for the application's Info.plist file.

[KrauseFx]

Thanks for the pull request. I don't have any Swift projects yet.

Could you change the line to

   if ['.plist', '.bundle', '.framework'].any? { |a| file.name.include?a }

and test if it works? It's more Ruby like 👍

[lvillani]

@KrauseFx It doesn't seem to work.

[KrauseFx]

Are you sure?
I just tried this locally:

irb(main):002:0> ['.plist','.bundle', '.framework'].any?{|a| "name.bundle".include?a}
=> true
irb(main):003:0> ['.plist','.bundle', '.framework'].any?{|a| "name.somethingelse".include?a}
=> false

[lvillani]

I had to change the guard to something like:

if file.name.include?'.plist' and not ['.bundle', '.framework'].any? { |a| file.name.include?a }

(I need to exclude Info.plist files coming from within frameworks)

[KrauseFx]

Oh, I'm sorry, that was my mistake. Nice catch! Looks good

[KrauseFx]

Could you add that? I'll merge the PR then.

[lvillani]

Done and tested locally 😉

[KrauseFx]

Thanks @lvillani! 👍

[KrauseFx]

Just released a new version for this fix: https://github.com/KrauseFx/deliver/releases

[KrauseFx]

Hey @lvillani
Just curios: Did you submit a swift app using deliver? I read about issues on the Apple dev forum: https://devforums.apple.com/thread/245492
Did it work?

[lvillani]

@KrauseFx Yes but I had to build the IPA with Xcode and then export an IPA from the Organizer. Alternatively, there are a couple of scripts around which inject the "SwiftSupport" directory in the IPA file. I'm going to file a bug report to push for a fix in xcodebuild (either that or remove the PackageApplication step altogether, since in the current form it doesn't really work. They say it is "not supported" but leaving an half-implemented feature lying around is as detrimental as not having it at all).

[KrauseFx]

Good to know. So, you can prepare and test a fix for Swift projects? Unfortunately I don't have any apps, which are built with Swift to test it...

[lvillani]

Are we talking about adding a test case for this issue or for another one?

[KrauseFx]

Sorry, I was not talking about unit tests. I meant more like: Could you (manually) test the submission of a Swift app with one of those scripts you were talking about?
I think I'll just create a demo swift app and will work on this issue.

[KrauseFx]

@lvillani Could you send me some links to the tools which helped you?

[lvillani]

I built my app with Xcode's GUI, then exported the IPA and did the final upload with deliver. The script I was talking about is here but I have yet to try it.

[KrauseFx]

@lvillani it looks like @sinoru found a solution for the Swift problem: nomad-cli/shenzhen#178

[lvillani]

Cool! I might give it a try the next time I push an update.

[KrauseFx]

@lvillani Thanks, please let me know, once you know more. I don't have any swift production apps right now.
You can report back on this issue: #42