Skip to content
This repository has been archived by the owner on Nov 19, 2018. It is now read-only.

Fix const check #40

Closed
KrauseFx opened this issue May 26, 2015 · 5 comments
Closed

Fix const check #40

KrauseFx opened this issue May 26, 2015 · 5 comments

Comments

@KrauseFx
Copy link
Contributor

@snatchev this is not working on my machine: a362bfc

I had to disable the check for the initial beta release. Maybe this depends on the Ruby version? I'm on ruby 2.0.0p481.

@KrauseFx KrauseFx added this to the spaceship 0.1.0 milestone May 26, 2015
@snatchev
Copy link
Contributor

@KrauseFx I was running under ruby 2.2.0 I will test it with your version and see if I am using some new methods. Can you attach a stacktrace if possible? rspec -b should print out full traces.

@KrauseFx
Copy link
Contributor Author

Thanks @snatchev

Here's the stack trace:

  1) Spaceship::Base Class Methods can constantize subclasses by calling a method on the parent class
     Failure/Error: expect(Developer.ruby_developer).to eq(Developer::RubyDeveloper)
     NameError:
       wrong constant name Developer::RubyDeveloper
     # ./lib/spaceship/base.rb:56:in `const_defined?'
     # ./lib/spaceship/base.rb:56:in `method_missing'
     # ./spec/spaceship_base_spec.rb:49:in `block (3 levels) in <top (required)>'
     # /Library/Ruby/Gems/2.0.0/gems/rspec-core-3.1.7/lib/rspec/core/example.rb:152:in `instance_exec'
     # /Library/Ruby/Gems/2.0.0/gems/rspec-core-3.1.7/lib/rspec/core/example.rb:152:in `block in run'
     # /Library/Ruby/Gems/2.0.0/gems/rspec-core-3.1.7/lib/rspec/core/example.rb:329:in `with_around_example_hooks'
     # /Library/Ruby/Gems/2.0.0/gems/rspec-core-3.1.7/lib/rspec/core/example.rb:149:in `run'
     # /Library/Ruby/Gems/2.0.0/gems/rspec-core-3.1.7/lib/rspec/core/example_group.rb:490:in `block in run_examples'
     # /Library/Ruby/Gems/2.0.0/gems/rspec-core-3.1.7/lib/rspec/core/example_group.rb:486:in `map'
     # /Library/Ruby/Gems/2.0.0/gems/rspec-core-3.1.7/lib/rspec/core/example_group.rb:486:in `run_examples'
     # /Library/Ruby/Gems/2.0.0/gems/rspec-core-3.1.7/lib/rspec/core/example_group.rb:453:in `run'
     # /Library/Ruby/Gems/2.0.0/gems/rspec-core-3.1.7/lib/rspec/core/example_group.rb:454:in `block in run'
     # /Library/Ruby/Gems/2.0.0/gems/rspec-core-3.1.7/lib/rspec/core/example_group.rb:454:in `map'
     # /Library/Ruby/Gems/2.0.0/gems/rspec-core-3.1.7/lib/rspec/core/example_group.rb:454:in `run'
     # /Library/Ruby/Gems/2.0.0/gems/rspec-core-3.1.7/lib/rspec/core/runner.rb:111:in `block (2 levels) in run_specs'
     # /Library/Ruby/Gems/2.0.0/gems/rspec-core-3.1.7/lib/rspec/core/runner.rb:111:in `map'
     # /Library/Ruby/Gems/2.0.0/gems/rspec-core-3.1.7/lib/rspec/core/runner.rb:111:in `block in run_specs'
     # /Library/Ruby/Gems/2.0.0/gems/rspec-core-3.1.7/lib/rspec/core/reporter.rb:53:in `report'
     # /Library/Ruby/Gems/2.0.0/gems/rspec-core-3.1.7/lib/rspec/core/runner.rb:107:in `run_specs'
     # /Library/Ruby/Gems/2.0.0/gems/rspec-core-3.1.7/lib/rspec/core/runner.rb:85:in `run'
     # /Library/Ruby/Gems/2.0.0/gems/rspec-core-3.1.7/lib/rspec/core/runner.rb:69:in `run'
     # /Library/Ruby/Gems/2.0.0/gems/rspec-core-3.1.7/lib/rspec/core/runner.rb:37:in `invoke'
     # /Library/Ruby/Gems/2.0.0/gems/rspec-core-3.1.7/exe/rspec:4:in `<top (required)>'
     # /usr/bin/rspec:23:in `load'
     # /usr/bin/rspec:23:in `<main>'

@snatchev
Copy link
Contributor

This is really strange. I cannot reproduce this exception. Using ruby 2.0.0p481 (2014-05-08 revision 45883)

Is this Apple's stock ruby?

@snatchev
Copy link
Contributor

Was able to reproduce the issue and fixed it in 1b838fd. Looks like behavior of that method changed in more recent rubies.

@fastlanebot
Copy link

This issue was migrated to fastlane/fastlane#3554. Please post all further comments there.

fastlane is now a mono repo, you can read more about the change in our blog post. All tools are now available in the fastlane main repo 🚀

@fastlane-old fastlane-old locked and limited conversation to collaborators Mar 12, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants