Review comments

fastlane · Apr 17, 2018 · 4f95c9e · 4f95c9e
1 parent b336e4f
commit 4f95c9e
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 20 deletions.
diff --git a/web/app/common/constants.ts b/web/app/common/constants.ts
@@ -9,24 +9,20 @@ export enum BuildStatus {
 export type FastlaneStatus =
     'failure'|'success'|'ci_problem'|'pending'|'missing_fastfile';
 
-export function fastlaneStatusToEnum(status?: FastlaneStatus): BuildStatus | undefined {
-  if (status) {
-    switch (status) {
-      case 'success':
-        return BuildStatus.SUCCESS;
-      case 'failure':
-        return BuildStatus.FAILED;
-      case 'pending':
-        return BuildStatus.PENDING;
-      case 'missing_fastfile':
-        return BuildStatus.MISSING_FASTFILE;
-      case 'ci_problem':
-        return BuildStatus.INTERNAL_ISSUE;
-      default:
-        throw new Error(`Unknown status type ${status}`);
-    }
-  } else {
-    return undefined;
+export function fastlaneStatusToEnum(status: FastlaneStatus): BuildStatus {
+  switch (status) {
+    case 'success':
+      return BuildStatus.SUCCESS;
+    case 'failure':
+      return BuildStatus.FAILED;
+    case 'pending':
+      return BuildStatus.PENDING;
+    case 'missing_fastfile':
+      return BuildStatus.MISSING_FASTFILE;
+    case 'ci_problem':
+      return BuildStatus.INTERNAL_ISSUE;
+    default:
+      throw new Error(`Unknown status type ${status}`);
   }
 }
 

diff --git a/web/app/dashboard/dashboard.component.spec.ts b/web/app/dashboard/dashboard.component.spec.ts
@@ -51,7 +51,7 @@ describe('DashboardComponent', () => {
     expect(component.projects[0].name).toBe('the coolest project');
     expect(component.projects[1].latestStatus).toBe(BuildStatus.SUCCESS);
     expect(component.projects[2].statusIcon).toBe('error');
-    expect(component.projects[3].latestDate).toBe(undefined);
+    expect(component.projects[3].latestDate).toBeUndefined();
     expect(component.projects[3].statusIcon).toBe('pause_circle_filled');
   });
 });
diff --git a/web/app/models/project_summary.ts b/web/app/models/project_summary.ts
@@ -20,7 +20,7 @@ export class ProjectSummary {
     this.name = projectSummary.name;
     this.id = projectSummary.id;
     this.lane = projectSummary.lane;
-    this.latestStatus = fastlaneStatusToEnum(projectSummary.latest_status);
+    this.latestStatus = projectSummary.latest_status ? fastlaneStatusToEnum(projectSummary.latest_status) : undefined;
     this.statusIcon = buildStatusToIcon(this.latestStatus);
     this.latestDate = projectSummary.latest_timestamp ? new Date(projectSummary.latest_timestamp) : undefined;
   }