params[:repo_url] can be empty string

Trim it.
fastlane · Jun 20, 2018 · a7e7c6c · a7e7c6c
1 parent c6b1af5
commit a7e7c6c
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/app/features/onboarding/onboarding_controller.rb b/app/features/onboarding/onboarding_controller.rb
@@ -151,6 +151,7 @@ class OnboardingController < ControllerBase
           scopes, required = scope_validation_error
           scopes_list_wording = scopes.count > 0 ? scopes.map { |scope| "\"#{scope}\"" }.join(",") : "empty"
           scopes_wording = scopes.count > 1 ? "scopes" : "scope"
+          # rubocop:disable Metrics/LineLength
           error_message = "Token should be in \"#{required}\" scope, currently it's in #{scopes_list_wording} #{scopes_wording}."
           # rubocop:enable Metrics/LineLength
           flash[:error] = "#{error_message} See the image below."
@@ -175,10 +176,9 @@ class OnboardingController < ControllerBase
     #
     # 2) Redirect back to `/configuration`
     post "#{HOME}/git_repo" do
-    repo_url = params[:repo_url] || DEFAULT_REPO_URL
+      repo_url = params[:repo_url]&.strip! || DEFAULT_REPO_URL
       Services.dot_keys_variable_service.write_keys_file!(
-        locals: { :repo_url => repo_url }
-        )
+        locals: { repo_url: repo_url }
       )
       Services.configuration_repository_service.setup_private_configuration_repo
       Services.onboarding_service.clone_remote_repository_locally