Update to python3 and add pipenv #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
revolter
force-pushed
the
feature/python3-and-pipenv
branch
from
ea03173
to
7f0d2ed
Compare
revolter
force-pushed
the
feature/python3-and-pipenv
branch
from
7f0d2ed
to
c720723
Compare
|
Sincerely, I never liked how Python made the dependency management. IMO pip is a tool where the concept: "works in my computer" gets real. I'm happy to see new alternatives and seems pretty solid for me. |
minuscorp
approved these changes
Apr 8, 2018
|
Yup, pipenv is the best. I also love that it manages the virtual environments automatically, and also stores them outside the project's directory. |
revolter
commented
Apr 8, 2018
| ruby: | ||
| version: 2.3.0 | ||
| dependencies: | ||
| pre: | ||
| - pip install -r requirements.txt | ||
| - pip install pipenv | ||
| - pipenv install |
There was a problem hiding this comment.
Can't get easier than this ❤️
getaaron
approved these changes
Apr 9, 2018
|
This looks great 👍 |
joshdholtz
approved these changes
Apr 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I mentioned in #560, this simplifies the installation instructions and adding a new dependency.
Also, the current
requirements.txtandrequirements-to-freeze.txtare incorrect for two reasons:markdown-includeis missing from therequirements-to-freeze.txtbackports-abcdon't seem to be needed, as they're missing from the auto-generatedPipfile.lockThis way, you can also make sure you use a specific version (or a minimum), more similar to
GemfileandGemfile.lockthan therequirements*.txtfiles.It's also a wrapper over
virtualenvandpip, so it's not actually replacing anything.I would also want to know if updating to Python 3 has any drawbacks, even though CircleCI succeeded.