Skip to content

Commit

Permalink
fix bug when canceling a rejected submission (#20754)
Browse files Browse the repository at this point in the history
Co-authored-by: Connor Merchant <cmerchant@insiderealestate.com>
  • Loading branch information
merchang and Connor Merchant committed Nov 16, 2022
1 parent 7cb9367 commit bae43ea
Showing 1 changed file with 2 additions and 6 deletions.
8 changes: 2 additions & 6 deletions deliver/lib/deliver/runner.rb
Original file line number Diff line number Diff line change
Expand Up @@ -245,13 +245,9 @@ def reject_version_if_possible
UI.message("Review submission cancellation has been requested")

# An app version won't get removed from review instantly
# Polling until app version has a state of DEVELOPER_REJECT
# Polling until there is no longer an in-progress version
loop do
version = app.get_edit_app_store_version(platform: platform)
if version.app_store_state == Spaceship::ConnectAPI::AppStoreVersion::AppStoreState::DEVELOPER_REJECTED
break
end

break if app.get_in_progress_review_submission(platform: platform).nil?
UI.message("Waiting for cancellation to take effect...")
sleep(15)
end
Expand Down

0 comments on commit bae43ea

Please sign in to comment.