increment_build_number should not modify plist files

[ir-fuel]

I noticed that using increment_build_number modifies info.plist directly.

The thing is that normally that plist file contains: $(CURRENT_PROJECT_VERSION) as the build number, which is a value configured inside the project settings

The downside of editing the plist directly using increment_build_number is that the value shown above is no longer in sync with the value that's actually used. Wouldn't it be better to just edit the value inside the xcodeproj file and not touch the plist? I understand it's currently working differently but maybe expose a parameter that would allow us to switch between both ways of modifying the build number could solve that?

[joshdholtz]

I completely agree with this! $(CURERNT_PROJECT_VERSION) is used/referenced in get_version_number but... increment_build_number, get_build_number, and increment_version_number all need to get updated 😇

We should definitely get this changed 👍