-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Could not find a matching code signing identity for type 'AdHoc'. You can use cert to generate one #11139
Comments
It seems like this issue might be related to code signing 🚫 Have you seen our new Code Signing Troubleshooting Guide? It will help you resolve the most common code signing issues 👍 |
It seems like you have not included the output of To make it easier for us help you resolve this issue, please update the issue to include the output of |
i found this bug in match/runner.rb file in line 170 def certificates_for_profile_and_platform
case Sigh.config[:platform].to_s
when 'ios', 'tvos'
if profile_type == Spaceship.provisioning_profile.Development
certificates = Spaceship.certificate.development.all
elsif profile_type == Spaceship.provisioning_profile.InHouse
certificates = Spaceship.certificate.in_house.all
else
certificates = Spaceship.certificate.production.all # Ad hoc or App Store
**certificates = certificates | Spaceship.certificate.in_house.all #I add this line**
end |
Thanks for finding the code @dlxxl06 ! Could you point to which line it is exactly? I'm seeing a different line 70 on master than this code snippet you shared. 🚀 |
Is this fixed and released? I'm having the same issue with an enterprise account generating AdHoc profile. |
Hey! |
Feedback please? |
Hey! I'm also having the same issue (an enterprise account trying to generate an AdHoc profile). The problem seems to be the one mentioned by @dlxxl06, and adding the code line he is proposing after line 180 in the following snippet should fix the issue. fastlane/sigh/lib/sigh/runner.rb Lines 174 to 181 in 181a4c1
|
@polmum Thanks for linking that! Will look into 👀 |
There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest |
This has not been fixed and there is a code proposed as fix. It looks to me that a maintainer has to decide if it makes sense to add that code. |
Hey all 👋 I made what I think is a fix for how |
Hmmm I'm still running into this issue @joshdholtz. I haven't seen this before, it definitely has to do with match and enterprise accounts creating adhoc certs. I'm on version 2.94.0. I ran Here's the output when I run it: [17:32:04]: Successfully loaded '/Users/brendan/Github/MY_PROJECT/fastlane/Matchfile' 📄 When I run
Importing the key and cert both succeed but this message is printed out to the console. This also gets printed:
|
@joshdholtz I did a bit more digging, it looks like maybe it's a bug in Spaceship. I |
I was able to figure it out! Turns out the bug is in Sigh and how it uses Spaceship. First, to get certs, there's a call to IOS_CERTIFICATE_TYPE_IDS = {
"5QPB9NHCEI" => Development,
"R58UK2EWSO" => Production,
"9RQEK7MSXA" => InHouse,
"LA30L5BJEU" => Certificate,
"BKLRAVXMGM" => DevelopmentPush,
"UPV3DW712I" => ProductionPush,
"Y3B2F3TYSI" => Passbook,
"3T2ZP62QW8" => WebsitePush,
"E5D663CMZW" => VoipPush,
"4APLUP237T" => ApplePay
} the list returns empty so it was failing despite the certificate existing in the developer portal. I went through and tried a couple different ones and it turns out if you're trying to fetch an adhoc certificate from an enterprise account, you can get it but only if the value of elsif profile_type == Spaceship.provisioning_profile.AdHoc && Spaceship.client.in_house?
certificates = Spaceship.certificate.in_house.all
else in this method (runner.rb: 172, the last def certificates_for_profile_and_platform
case Sigh.config[:platform].to_s
when 'ios', 'tvos'
if profile_type == Spaceship.provisioning_profile.Development
certificates = Spaceship.certificate.development.all
elsif profile_type == Spaceship.provisioning_profile.InHouse
certificates = Spaceship.certificate.in_house.all
elsif profile_type == Spaceship.provisioning_profile.AdHoc && Spaceship.client.in_house?
certificates = Spaceship.certificate.in_house.all
else
certificates = Spaceship.certificate.production.all # Ad hoc or App Store
end
when 'macos'
if profile_type == Spaceship.provisioning_profile.Development
certificates = Spaceship.certificate.mac_development.all
elsif profile_type == Spaceship.provisioning_profile.AppStore
certificates = Spaceship.certificate.mac_app_distribution.all
elsif profile_type == Spaceship.provisioning_profile.Direct
certificates = Spaceship.certificate.developer_id_application.all
else
certificates = Spaceship.certificate.mac_app_distribution.all
end
end When that happens, both the adhoc and enterprise certificate we use returned from the API call and match was able to set up adhoc certificates successfully. I can put up a PR that fixes this if that sounds good @KrauseFx @joshdholtz |
@startupthekid Great find! If you want to put up a PR for this and mention me that would be ❤️ I would be happy to test it out 🙃 Sent with GitHawk |
Definitely! I'll get that up today. |
+1. Just ran into this. |
Addressed in #12467 |
New Issue Checklist
Issue Description
Complete output when running fastlane, including the stack trace and command used
No existing profiles found, that match the certificates you have installed locally! Creating a new provisioning profile for you
WARN [2017-12-07 18:10:40.07]: No certificates for filter: Certificate ID: 'NGMBD6E3T8'
ERROR [2017-12-07 18:11:40.09]: Unable to send the crash report.
ERROR [2017-12-07 18:11:40.09]: Please open an issue on GitHub if you need help!
Environment
fastlane --version 2.68.0 match 2.68.0 sigh 2.68.0
this is a enterprise account
match(type: "#{type}",
verbose: true,
force: true,
app_identifier: "#{app_identifier}",
git_branch: ENV['MATCH_INHOUSE_BRANCH'],
clone_branch_directly: true,
force_for_new_devices: true,
provisioning_name: "#{provisioning_name}",
username: "dlxdell@hotmail.com",
team_id: "SHDWRXPG6N")
The text was updated successfully, but these errors were encountered: