[match] Correct how match handles enterprise adhoc

[joshdholtz]

Fixes #11139
Fixes #12133

Da motivation

I have experience this issue while (as well as others) where match doesn't treat adhoc profiles for enterprise accounts the way it is expected.

❌ Before

• match would place certificates for enterprise adhoc accounts under distribution
  • This meant that match wouldn't reuse the same cert used for inhouse which was placed under enterprise
• sigh would also look for enterprise adhoc files in Spaceship.certificate.production.all when actually in Spaceship.certificate.in_house.all

✅ After

• match looks for both enterprise adhoc and inhouse certs under the enterprise directory
  • Which now means the one certificate can be shared for all enterprise distribution builds
• sigh now properly returns certificates for enterprise adhoc profiles

⚠️ Warning

• This may introduce some backwards compatibility issues 🤔
  • match will now look for the adhoc cert in the enterprise directory instead of distribution
  • This shouldn't "break" anything but will make the other certificate just useless

[logancautrell]

Thank you for getting a fix up for this :)

[KrauseFx]

Haven't tried it, but code looks 👍

[wanyakun]

After i update fastlane to version 2.92.0, when i use match sync the adhoc certificates got the error as follow:
undefined method `in_house?' for nil:NilClass.

As you said match will now look for the adhoc cert in the enterprise directory instead of distribution.

But in my git project there is no enterprise directory, and my apple account is not enterprise. So it won't create enterprise directory.

  def self.cert_type_sym(type)
    return :enterprise if type == "enterprise" || (type == "adhoc" && Spaceship.client.in_house?)
    return :development if type == "development"
    return :distribution if ["adhoc", "appstore", "distribution"].include?(type)
    raise "Unknown cert type: '#{type}'"
  end

Then i found the in_house method is not in the client.rb file and it is in the portal_base.rb file.

[arthuryeti]

Same as you @wanyakun. Do you guys have an idea?

[Steveybrown]

As a temp solution, I downgraded back to 2.91.0

Gemfile
gem "fastlane", '2.91.0'

[wanyakun]

@ATU i remove this line return :enterprise if type == "enterprise" || (type == "adhoc" && Spaceship.client.in_house?) in method cert_type_sym for the moment. Or downgraded back to 2.91.0 as @Steveybrown

[joshdholtz]

Hey everyone! Sorry about this. Going to revert it 😬

[joshdholtz]

Reverted this PR and making new version for 2.92.1

[fastlane-bot]

Congratulations! 🎉 This was released as part of fastlane 2.92.0 🚀