resign creates an archived-expanded-entitlements.xctent that prevents uploads to AppStore

[lyndsey-ferguson]

New Issue Checklist

• Updated fastlane to the latest version
• I read the Contribution Guidelines
• I read docs.fastlane.tools
• I searched for existing GitHub issues

Issue Description

The iOS App Store is rejecting an application that was resigned due to the following:

ERROR ITMS-90046: "Invalid Code Signing Entitlements. Your application bundle's signature contains code signing entitlements that are not supported on iOS. Specifically, value 'Development' for key 'com.apple.developer.icloud-container-environment' in 'Payload/Appian.app/Appian' is not supported."

The only file that has that entry is archived-expanded-entitlements.xcent. This file did not exist in the original signed app built by Xcode 10. This file is being added by resign.sh, and as of Xcode 9.3, that file is no longer required.

Complete output when running fastlane, including the stack trace and command used

This is the output when the attempt to upload the app is made

1 package(s) were not uploaded because they had problems:
	/var/folders/7d/_phz8r5n20d6wk5czqv911w80000gn/T/AA042A1B-DAA5-4928-89AC-3EA5B4728DE7/1440851300.itmsp - Error Messages:
		ERROR ITMS-90046: "Invalid Code Signing Entitlements. Your application bundle's signature contains code signing entitlements that are not supported on iOS. Specifically, value 'Development' for key 'com.apple.developer.icloud-container-environment' in 'Payload/Resigned.app/Resigned' is not supported."
		ERROR ITMS-90045: "Invalid Code Signing Entitlements. Your application bundle's signature contains code signing entitlements that are not supported on iOS. Specifically, key 'com.apple.developer.icloud-container-development-container-identifiers' in 'Payload/Resigned.app/Resigned' is not supported."
		ERROR ITMS-90046: "Invalid Code Signing Entitlements. Your application bundle's signature contains code signing entitlements that are not supported on iOS. Specifically, value '*' for key 'com.apple.developer.icloud-services' in 'Payload/Resigned.app/Resigned' is not supported."
		ERROR ITMS-90179: "Invalid Code Signing. The executable 'Payload/Resigned.app/Resigned' must be signed with the certificate that is contained in the provisioning profile."
		ERROR ITMS-90211: "Invalid Code Signing Entitlements. The signature for your app bundle contains entitlement values that are not supported. For the com.apple.developer.ubiquity-kvstore-identifier entitlement, the value must start with the prefix provided by Apple in the provisioning profile, followed by characters that are uppercase or lowercase Roman letters [A-Z, a-z], the digits 0 through 9, dot ['.'], or hyphen ['-'], and not contain any wildcard characters. Specifically, value '45XRUNV253.*' for the key 'com.apple.developer.ubiquity-kvstore-identifier' in 'Payload/Resigned.app/Resigned' is not supported."
 

Environment

Xcode 10.0
  

[lyndsey-ferguson]

I will add code to resign.sh to check for the version of Xcode. If it is Xcode 10 or later, it won't create the xcent file any longer.