Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[resign.sh] only create the archived-expanded-entitlements.xcent file if the version of Xcode < 9.3 #13685

Merged
merged 2 commits into from Nov 18, 2018
Merged

[resign.sh] only create the archived-expanded-entitlements.xcent file if the version of Xcode < 9.3 #13685

merged 2 commits into from Nov 18, 2018

Conversation

lyndsey-ferguson
Copy link
Contributor

@lyndsey-ferguson lyndsey-ferguson commented Nov 14, 2018 •
edited by janpio

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

As of Xcode 10, the App Store will no longer accept xcent files created by extracting the elements from the provisioning profile. Additionally, this file is not necessary. See this Issue for more information.

Description

Get the Xcode version and use that to determine whether or not we need to create a new xcent file for resigning.

closes #13684

@lyndsey-ferguson
Copy link
Contributor Author

@ryanprobus, @matt-demers, @kpink224 can you review this?

ryanprobus
ryanprobus approved these changes Nov 14, 2018
View reviewed changes
Copy link
Contributor

@ryanprobus ryanprobus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@matt-demers
Copy link

Looks good to me

kpink224
kpink224 reviewed Nov 14, 2018
View reviewed changes
Copy link

@kpink224 kpink224 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG just a nit syntax change.

sigh/lib/assets/resign.sh Outdated Show resolved Hide resolved
@lyndsey-ferguson lyndsey-ferguson force-pushed the issue-13684-no-more-xcent-for-xcode10 branch from 7947112 to f3ec4d8 Compare November 14, 2018 20:38
@janpio janpio changed the title issue-13684 fixes Xcode10 issue where invalid xcent file created [resign.sh] only create the archived-expanded-entitlements.xcent file if the version of Xcode < 9.3 Nov 14, 2018
@lyndsey-ferguson
Copy link
Contributor Author

lyndsey-ferguson commented Nov 14, 2018 •
edited

@janpio curious, do changes to one file always get prefixed with the filename?

@janpio
Copy link
Member

janpio commented Nov 14, 2018 •
edited

Nah, but resign.sh is kind of "a thing" in the codebase and previous PRs. It is very different to the rest of fastlane's code. I thought that adding it to the title helps to clarify what this PR is about. (Usually or sometimes the "tool" name is used in the title)

@lyndsey-ferguson lyndsey-ferguson force-pushed the issue-13684-no-more-xcent-for-xcode10 branch from f3ec4d8 to 7731693 Compare November 15, 2018 00:28
@lyndsey-ferguson
Copy link
Contributor Author

I discovered a problem, please refrain from merging

@lyndsey-ferguson lyndsey-ferguson force-pushed the issue-13684-no-more-xcent-for-xcode10 branch from 7731693 to 05cabd2 Compare November 16, 2018 19:28
@lyndsey-ferguson
Copy link
Contributor Author

Ok, ready to merge. I fixed the issue, a failure to sign the app binary, and have tested it on an iOS Enterprise app by importing it into my phone.

@janpio
Copy link
Member

janpio commented Nov 16, 2018

Umm, what was the problem and the change done? Because of the force push it's not visible here :/

@lyndsey-ferguson
Copy link
Contributor Author

The problem was that I had the if [[ "${XCODE_VERSION/.*/}" -lt 10 ]]; block around the entire block of code that would sign the binary. Thus, the binary was not resigned and the ipa bundle was not valid to be uploaded to an iPhone or to the AppStore.

joshdholtz
joshdholtz approved these changes Nov 18, 2018
View reviewed changes
Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for making this change ❤️

@joshdholtz joshdholtz merged commit 72f9953 into fastlane:master Nov 18, 2018
@lyndsey-ferguson
Copy link
Contributor Author

Thank you!

@fastlane-bot
Copy link

Hey @lyndsey-ferguson 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

mariannegru added a commit to mariannegru/fastlane that referenced this pull request Dec 3, 2018
@mariannegru
Merge remote-tracking branch 'upstream/master' into two-factor-phone-…
ce0a9a1 
…select

* upstream/master: (34 commits)
  Use HTTPs for Facebook frame URL (fastlane#13771)
  [spaceship] improve client (mainly: login) (fastlane#13736)
  [spaceship] Fix environment variable provided sessions (fastlane#13743)
  Allow for the host of the Appetize API to be configured (fastlane#13765)
  Improves parse error reporting for non-conventional setups (fastlane#13769)
  Use `crash!` instead of `user_error!` on configuration access mis-use (fastlane#13766)
  Rip out more dead analytics code (fastlane#13741)
  [spaceship] support --verbose for `fastlane spaceauth` (fastlane#13752)
  [fastlane_core] Fix project_paths() in project.rb to respect `container:` references (fastlane#13662)
  [precheck] Allow mentioning Google Drive (fastlane#13754)
  [crashlytics] fix generated command (generate_android_command) for Windows (fastlane#13597)
  [docs] add id to plugin headline so it becomes linkable (fastlane#13727)
  [match] add new option to recreate deleted profiles in dev portal (fastlane#12539)
  Update puts.rb (fastlane#13739)
  Improve Spaceship API documentation (fastlane#13724)
  Update gym docs (fastlane#13725)
  Testfairy upload timeout (fastlane#13674)
  [resign.sh] only create the archived-expanded-entitlements.xcent file if the version of Xcode < 9.3 (fastlane#13685)
  [spaceship] remove application and version from app submission params (fastlane#13695)
  Improve AdbHelper (fastlane#13692)
  ...

# Conflicts:
#	spaceship/lib/spaceship/two_step_or_factor_client.rb
@joshdholtz joshdholtz mentioned this pull request Dec 4, 2018
Merged
@fastlane-bot
Copy link

Congratulations! 🎉 This was released as part of fastlane 2.109.0 🚀

@fastlane fastlane locked and limited conversation to collaborators Feb 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@janpio janpio janpio left review comments

@kpink224 kpink224 kpink224 left review comments

@joshdholtz joshdholtz joshdholtz approved these changes

@ryanprobus ryanprobus ryanprobus approved these changes

Assignees
No one assigned
Labels
cla: yes status: released tool: sigh
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

resign creates an archived-expanded-entitlements.xctent that prevents uploads to AppStore
8 participants
@lyndsey-ferguson @matt-demers @janpio @fastlane-bot @joshdholtz @kpink224 @ryanprobus @googlebot