New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ITC Team ID specified in AppFile isn't being passed to connect_api; now I get "Multiple Teams found; unable to choose" #17371
Comments
I don't believe #17153 is somehow related. |
You also may try to run something like lane :temp do
puts CredentialsManager::AppfileConfig.try_fetch_value(:itc_team_id)
end If |
Adding this to my queue to look into this week! |
@Katsz Well, please remember that this was all working fine until two weeks ago, with no changes on my part. |
Running today, nokogiri seems to be one offender of the
and I did track down one @Katsz CredentialsManager did properly return the value for itc_team_id, as set in the Appfile.
quickly shows the problem for me. So I switched my .login to the long-form I don't understand why explicitly specifying the |
I think it's related to ongoing migration from old whatever API to ConnectAPI...
|
@Katsz I only don't care for the long-form because the real message it says in fastlane is something like "multiple teams found, defaulting to the first one". That still sounds like it is not respecting my choice, but rather I'm just luckily defaulting to the account I want. |
I am also specifying
Are there any temporary workarounds I can try until this is resolved? |
@joshdholtz Any updates on this issue? You put it in your queue about 3 weeks ago; just curious to know if anything suspicious turned up yet? |
Thanks for friendly ping! This should fall onto my Tuesday or Wednesday of this week! A few things from other fastlane related projects got interested in over the past few weeks along with some radar filing 🤷♂️ But nothing looks like it will be popping in this week so I should get to it soon ™️ |
Solving issue with workaround (#17371 (comment))I think you need to try setting This defaults to false so that https://github.com/fastlane/fastlane/blob/master/spaceship/lib/spaceship/connect_api/client.rb#L58-L70 gets executed which is needed to select the team(s) for the session. Spaceship::ConnectAPI.login(ENV['FASTLANE_USER'], ENV['FASTLANE_PASSWORD'],
use_portal: false,
use_tunes: true,
portal_team_id: nil,
tunes_team_id: ENV['itc_team_id'],
team_name: nil,
skip_select_team: false # Make this false
) Solving issue initially reportedThe issue you initially reported looks like it was asking to select the portal team (and not the ITC/tunes team)...
So it seems like what was happening was because both Solution 1The Spaceship::ConnectAPI.login(<username>, <password>, use_portal: false) Solution 2My preferred solution is that I always use team name instead of the id. The name is (usually) the same across both developer portal and tunes/itc so it can select the team from both. This might not work for everyone though Set the Take AwayI’m going to update the docs to explain more of the parameters on this new login method so there is less confusion and also give some examples |
@joshdholtz Thanks for the explanation. Given what you've said, it does seem that just a documentation update to clarify how/when these parameters are used and recommended best practices would be more than sufficient. I'll update my appfile and fastfile today. |
@ChristopherDrum Sounds great! Let me know the result if you don't mind 😊 I'll update the docs once I hear back from you just to make sure that everything here is 💯 |
@ChristopherDrum Just checking in to see if everything is good for you now 😊 |
@joshdholtz Well, I made a rookie mistake last week and put |
@joshdholtz I'm sorry to say I'm having no success with this. Changing to your suggestion results in consist failures.
I've set |
@ChristopherDrum That is weird! If you have some time this week I'd be happy to screenshare or something so we can debug what is going. I'd really love to figure out what is going on here 😊 |
@joshdholtz OK, exporting |
@ChristopherDrum Can you send me a sample of what your |
@joshdholtz Let me do an audit of sensitive info first. But, I can tell you that |
There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Friendly reminder: contributions are always welcome! Check out CONTRIBUTING.md for more information on how to help with |
This issue will be auto-closed because there hasn't been any activity for a few months. Feel free to open a new one if you still experience this problem 👍 |
New Issue Checklist
Issue Description
#17153 says it fixed this issue, but to make a new report if we still have the problem.
I still have the problem.
Haven't had any troubles for weeks, but this showed up when trying to do an automated submission on September 25.
Not sure what version of Fastlane I was on at that particular time, but I do run an update each week before submission.
As of October 2, I was on Fastlane v.2.162.0 and still have the issue.
Command executed
Spaceship::ConnectAPI.login(<username>, <password>)
itc_team_id
is defined in the AppFile, which was done explicitly to solve a "multiple team" issue in the past.Complete output when running fastlane, including the stack trace and command used
Environment
✅ fastlane environment ✅
Stack
System Locale
fastlane files:
`./Fastfile`
`./Appfile`
fastlane gems
Loaded fastlane plugins:
No plugins Loaded
Loaded gems
generated on: 2020-10-04
The text was updated successfully, but these errors were encountered: