-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Google Maps not working? #2081
Comments
@susanp Thanks for reporting. This appears to be a limitation of the current implementation. I think it is something that we can fix though. We'll update this issue when we have more information. |
any progress on this? I have used something like this before to create screenshots of the map:
|
@susanp Thanks for following up on this. I'm going to mark this as help wanted in case anyone wants to submit a PR with this functionality. Thanks for working with us 👍 |
@TKBurner Is there any update to that issue? |
I solved this by adding some code from here: I will make a pull request for this later.
|
I am not sure if the licenses of mapbox-gl-native and fastlane are compatible |
@mozinator Thanks for letting us know. What makes you think they aren't compatible? I'd love to let the know! |
fastlane has a MIT license |
I sent an email to Antonio from the mapbox-gl-native project to ask for permission to use his code in fastlane |
@mozinator Thanks! Let us know what you find out 👍 |
@mozinator Thanks for engagement! Did you receive any response from mapbox team? |
yes, all positive, we are free to use his code as we like. but we should mention that it came from him |
Great, @TKBurner could you merge this feature? |
Please link to the PR that you'd like reviewed. If there isn't one yet, please submit one and we'll take a look. 👍 |
Implements a fix that makes Google Maps and other TextureViews visible in screenshots Based on comment by @mozinator and source code from the mapbox-gl-native project
As I needed this fix for my own project, I took the liberty to create the pull request to expedite the process. |
@PaulWagener Awesome! We'll work with you there. I'm going to close this out for now in favor of your PR. |
Link to the PR: /pull/5471 |
Thanks @tompesman we'll work with you there 👍 |
I think screenshots of Google Maps aren't working. Is that to be expected or can I do something about it?
The text was updated successfully, but these errors were encountered: