New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Listing apps fails, due to the recent pricing update on App Store? #21125
Comments
It seems like you have not included the output of |
Same issue here |
Yep, we ran into the same issue when uploading to the AppStore with Fastlane.
|
Same here. We cannot upload using Fastlane. |
Just ran into this issue as well. I sort of need my CI to be building my apps (secrets, config steps that run, etc) so I started testing locally and just commenting out "prices" fixes the problem (unsurprisingly):
Of course if you make use of prices via fastlane it will probably break but I don't. I'm going to look into patching this file on the fly in my CI to comment out that line to see if I can successfully get |
Ok I'm able to run --- vendor/bundle/ruby/3.2.0/gems/fastlane-2.211.0/spaceship/lib/spaceship/connect_api/models/app-original.rb 2023-03-10 18:42:18.000000000 -0500
+++ vendor/bundle/ruby/3.2.0/gems/fastlane-2.211.0/spaceship/lib/spaceship/connect_api/models/app.rb 2023-03-10 18:42:39.000000000 -0500
@@ -59,7 +59,7 @@
ESSENTIAL_INCLUDES = [
"appStoreVersions",
- "prices"
+# "prices"
].join(",")
def self.type
And I added the following to my GH Actions workflow:
Obviously this only works if you use ruby 3.2.0 and fastlane 2.11.0 but the basic idea should work for any version of either. I created the patch by starting in root of my project (after I copied diff -Naur vendor/bundle/ruby/3.2.0/gems/fastlane-2.211.0/spaceship/lib/spaceship/connect_api/models/app-original.rb vendor/bundle/ruby/3.2.0/gems/fastlane-2.211.0/spaceship/lib/spaceship/connect_api/models/app.rb > fastlane-prices-fix.patch (Again, adjust for ruby/fastlane version). Nothing I did here is setting the world on fire but it unblocked me and so I wanted to share in case it helps someone else who was planning on using fastlane until this is fixed. |
Thanks @joshstrange - that worked for me too. I forked the repo, committed the change, and updated |
See also: fastlane#21125
See also: fastlane#21125
Same here, im using fastlane with my CI environment and i cannot upload versions |
We are getting the same error today ➕ |
Same error on 2.212.1 too. |
Same here with ruby 3.0.0 and fastlane 2.212.1. @joshstrange's workaround helps out. 😘 |
Just use this in Spaceship::ConnectAPI::App.const_set('ESSENTIAL_INCLUDES', 'appStoreVersions') |
@sck-v could you provide more details please? i put this into Fastfile, but no changes, still issue |
Maybe you would also need to |
@sck-v @joshstrange any idea how can I try that solution on azure devops? I create all these steps in the pipeline |
base on our test this solution works, require 'spaceship'
Spaceship::ConnectAPI::App.const_set('ESSENTIAL_INCLUDES', 'appStoreVersions') add these 2 lines in the top of Fastline file
|
For me, this was working only from Appfile |
We tried this but are now getting this error:
|
not sure, maybe the version? we are on 2.211.0, maybe you can try upgrade
|
fastlane/deliver/lib/deliver/upload_price_tier.rb Lines 19 to 32 in e55138d
I have a similar issue for a completely new app we're building where prices haven't been set before. I edited the code to return early and seems to have fixed the issue. The correct solution is to update fastlane to handle the new price App Store Connect API updates.
|
I bet monkeypatch may help here as well. Something like this should fix the exception Spaceship::ConnectAPI::App.class_eval do
def prices
[]
end
end |
For me using version 2.213.0 fixed the issue. |
This is till causing issues with version 2.214.0. As our app was free, we just ignored the price updates but please look into a proper fix for this. 🙏 |
i am using fastlane version 2.214.0. and my app was free app but we are are still facing the issue. please suggest any proper solution |
I have the same problem since I sent the app for review (not sure if it's related, but it's the 1st time I've sent a new build since). |
im also having this issue for 13 out of 62 apps released with fastlane, they use the exact same fastlane file, app file and deliver file, its the same app project released to 62 different accounts so its very weird that it would work for some of them and not others. |
Edit: removing
|
I just hit this. If you comment out
I then manually went into App Store Connect, selected free, all countries, and then everything went through ok. |
This issue occurs when we change the Base country or Region in pricing and availability section and select he base price for the app. For example by default base country or region is United States and if we change it to United Kingdom and choose the price as £0.00 or any other price, this issue occurs. |
then what's the use of using fastlane for automation. |
See fastlane/fastlane#21125 Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>
See fastlane/fastlane#21125 Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>
See fastlane/fastlane#21125 Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>
We are still having this issue, and reading the comments it looks like alot of other people are also still facing this, why has it be changed to closed? |
@assembleMHN Make sure you are using a newer version of fastlane Check your output to make sure you are using that version as well! |
@memoriasIT thank you for your response, im always on the newest, current on 2.220.0, and the issue sadly still persists. |
@assembleMHN We may have actually just had this recur today after having no issues (I think we removed price_tier from our Deliverfile, though). Maybe there's another change with the ASC API? Or a coincidence that we're both seeing it today. |
Were you able to get rid from this error? We previously removed the price_tier as well but this error went back recently. |
Unfortunately, for me at least, it's still an issue (although we haven't updated Fastlane in a few versions). It's been low enough priority that I haven't dug into it, since we just create the ASC entries manually. |
Actually, I take it back. Our latest issue is #21820 We will update fastlane |
New Issue Checklist
Issue Description
When I run the action
app_store_build_number
, it fails with an error response from Connect API:The request cannot be fulfilled because of the state of another resource. - The resource 'appPrices' cannot be viewed, created or updated. Please view and create 'manualPrices' using the resource 'appPriceSchedules'.
fastlane summary
and stack traceAs far as I look over the stack trace, I suppose it's caused by the recent pricing change on App Store and the related Connect API update.
https://developer.apple.com/news/releases/?id=03092023b
The
prices
attribute included inESSENTIAL_INCLUDES
:fastlane/spaceship/lib/spaceship/connect_api/models/app.rb
Lines 60 to 63 in e55138d
... looks now marked as deprecated.
https://developer.apple.com/documentation/appstoreconnectapi/app/relationships
Environment
✅ fastlane environment ✅
This is my local environment and it might be not so meaningful as the error above happened on my CI environment
Stack
System Locale
fastlane files:
`./fastlane/Fastfile`
No Appfile found
fastlane gems
Loaded fastlane plugins:
Loaded gems
generated on: 2023-03-10
The text was updated successfully, but these errors were encountered: