Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use with gym #3295

Closed
fastlanebot opened this issue Sep 23, 2015 · 16 comments
Closed

Use with gym #3295

fastlanebot opened this issue Sep 23, 2015 · 16 comments

Comments

@fastlanebot
Copy link

Original issue by @parthmind - Imported from fastlane/pilot#37

Can we not set pilot to work with gym, as now it is not taking IPA_OUTPUT_PATH of gym.

for now, i have to use following additional command to come out from this.
ENV["PILOT_IPA"] = ENV["IPA_OUTPUT_PATH"]

@fastlanebot
Copy link
Author

@KrauseFx commented

Good point, thanks, I'll update the fastlane integration 👍 Thanks for letting me know!

@fastlanebot
Copy link
Author

@KrauseFx commented

I just checked, the integration is using the ipa_output variable:

values[:ipa] ||= Actions.lane_context[SharedValues::IPA_OUTPUT_PATH]

Maybe do you have a different ipa file in your current directory? Or multiple ipa files?

@fastlanebot
Copy link
Author

@parthmind commented

I had override the output directory on gym using following method:

gym(output_directory: "./fastlane/")

I think, it must also override IPA_OUTPUT_PATH

@fastlanebot
Copy link
Author

@fatuhoku commented

Getting the same here — pilot is asking for the IPA directly after gym. Using pilot 0.2.1.

👍 for the workaround.

@fastlanebot
Copy link
Author

@KrauseFx commented

@fatuhoku Your issue seems to be caused by a release yesterday which had a race condition in fastlane_core. Could you please update using sudo gem update fastlane_core and let me know if this fixes your issue.

@fastlanebot
Copy link
Author

@klaaspieter commented

I'm using pilot 0.2.2 and fastlane 1.30.2 and am still seeing this issue.

@fastlanebot
Copy link
Author

@KrauseFx commented

I just used

lane :beta do
    gym
    pilot

and the output is

[20:00:10]: Successfully exported and compressed dSYM file
[20:00:10]: Successfully exported and signed the ipa file:
[20:00:10]: ./ExampleProductName.ipa
[20:00:10]: -------------------
[20:00:10]: --- Step: pilot ---
[20:00:10]: -------------------
[20:00:10]: Login to iTunes Connect (flapple@krausefx.com)
[20:00:22]: Login successful
[20:00:31]: Ready to upload new build to TestFlight (App: 1039164429)...
[20:00:31]: Going to upload updated app to iTunesConnect
[20:00:31]: This might take a few minutes, please don't interrupt the script

So it seems to be working. Are you using gym to build your app @klaaspieter?

@fastlanebot
Copy link
Author

@klaaspieter commented

I'm using gym with a custom build directory. Could that be the problem?

On Tue, Oct 6, 2015 at 20:01 Felix Krause notifications@github.com wrote:

I just used

lane :beta do
gym
pilot

and the output is

``
20:00:10 http://-------------------: Successfully exported and
compressed dSYM file
20:00:10 http://-------------------: Successfully exported and signed
the ipa file:

20:00:10 http://-------------------: --- Step: pilot ---

20:00:10 http://-------------------: Login to iTunes Connect (
flapple@krausefx.com)
[20:00:22]: Login successful
[20:00:31]: Ready to upload new build to TestFlight (App: 1039164429)...
[20:00:31]: Going to upload updated app to iTunesConnect
[20:00:31]: This might take a few minutes, please don't interrupt the
script

So it seems to be working. Are you using gym to build your app @klaaspieter?


Reply to this email directly or view it on GitHub
fastlane-old/pilot#37 (comment).

@fastlanebot
Copy link
Author

@KrauseFx commented

I'll check that

@fastlanebot
Copy link
Author

@KrauseFx commented

I can reproduce the issue, thanks! 👍

@fastlanebot
Copy link
Author

@KrauseFx commented

Please update pilot and let me know if that works for you 👍

@fastlanebot
Copy link
Author

@klaaspieter commented

Yep. It works now 👍

@fastlanebot
Copy link
Author

@KrauseFx commented

Yeah 👍

@fastlanebot
Copy link
Author

@bgerstle commented

thanks guys! to be clear, I don't have to pass ENV['IPA_OUTPUT_PATH'] to gym anymore?

@fastlanebot
Copy link
Author

@KrauseFx commented

@bgerstle it should work automatically using the latest version 👍

@fastlanebot
Copy link
Author

@bgerstle commented

super duper!

@fastlane fastlane locked and limited conversation to collaborators Sep 22, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant