Skip to content
This repository has been archived by the owner on Nov 19, 2018. It is now read-only.

Use with gym #37

Closed
ghost opened this issue Sep 23, 2015 · 17 comments
Closed

Use with gym #37

ghost opened this issue Sep 23, 2015 · 17 comments
Labels

Comments

@ghost
Copy link

ghost commented Sep 23, 2015

Can we not set pilot to work with gym, as now it is not taking IPA_OUTPUT_PATH of gym.

for now, i have to use following additional command to come out from this.
ENV["PILOT_IPA"] = ENV["IPA_OUTPUT_PATH"]

@KrauseFx
Copy link
Contributor

Good point, thanks, I'll update the fastlane integration 👍 Thanks for letting me know!

@KrauseFx
Copy link
Contributor

I just checked, the integration is using the ipa_output variable:

values[:ipa] ||= Actions.lane_context[SharedValues::IPA_OUTPUT_PATH]

Maybe do you have a different ipa file in your current directory? Or multiple ipa files?

@ghost
Copy link
Author

ghost commented Sep 24, 2015

I had override the output directory on gym using following method:

gym(output_directory: "./fastlane/")

I think, it must also override IPA_OUTPUT_PATH

@fatuhoku
Copy link

Getting the same here — pilot is asking for the IPA directly after gym. Using pilot 0.2.1.

👍 for the workaround.

@KrauseFx
Copy link
Contributor

@fatuhoku Your issue seems to be caused by a release yesterday which had a race condition in fastlane_core. Could you please update using sudo gem update fastlane_core and let me know if this fixes your issue.

@klaaspieter
Copy link

I'm using pilot 0.2.2 and fastlane 1.30.2 and am still seeing this issue.

@KrauseFx
Copy link
Contributor

KrauseFx commented Oct 7, 2015

I just used

lane :beta do
    gym
    pilot

and the output is

[20:00:10]: Successfully exported and compressed dSYM file
[20:00:10]: Successfully exported and signed the ipa file:
[20:00:10]: ./ExampleProductName.ipa
[20:00:10]: -------------------
[20:00:10]: --- Step: pilot ---
[20:00:10]: -------------------
[20:00:10]: Login to iTunes Connect (flapple@krausefx.com)
[20:00:22]: Login successful
[20:00:31]: Ready to upload new build to TestFlight (App: 1039164429)...
[20:00:31]: Going to upload updated app to iTunesConnect
[20:00:31]: This might take a few minutes, please don't interrupt the script

So it seems to be working. Are you using gym to build your app @klaaspieter?

@klaaspieter
Copy link

I'm using gym with a custom build directory. Could that be the problem?

On Tue, Oct 6, 2015 at 20:01 Felix Krause notifications@github.com wrote:

I just used

lane :beta do
gym
pilot

and the output is

``
20:00:10 http://-------------------: Successfully exported and
compressed dSYM file
20:00:10 http://-------------------: Successfully exported and signed
the ipa file:

20:00:10 http://-------------------: --- Step: pilot ---

20:00:10 http://-------------------: Login to iTunes Connect (
flapple@krausefx.com)
[20:00:22]: Login successful
[20:00:31]: Ready to upload new build to TestFlight (App: 1039164429)...
[20:00:31]: Going to upload updated app to iTunesConnect
[20:00:31]: This might take a few minutes, please don't interrupt the
script

So it seems to be working. Are you using gym to build your app @klaaspieter?


Reply to this email directly or view it on GitHub
#37 (comment).

@KrauseFx
Copy link
Contributor

KrauseFx commented Oct 8, 2015

I'll check that

@KrauseFx
Copy link
Contributor

KrauseFx commented Oct 8, 2015

I can reproduce the issue, thanks! 👍

@KrauseFx
Copy link
Contributor

KrauseFx commented Oct 8, 2015

Please update pilot and let me know if that works for you 👍

@klaaspieter
Copy link

Yep. It works now 👍

@KrauseFx
Copy link
Contributor

KrauseFx commented Oct 8, 2015

Yeah 👍

@bgerstle
Copy link

bgerstle commented Oct 8, 2015

thanks guys! to be clear, I don't have to pass ENV['IPA_OUTPUT_PATH'] to gym anymore?

@KrauseFx
Copy link
Contributor

KrauseFx commented Oct 8, 2015

@bgerstle it should work automatically using the latest version 👍

@bgerstle
Copy link

bgerstle commented Oct 8, 2015

super duper!

@fastlanebot
Copy link

This issue was migrated to fastlane/fastlane#3295. Please post all further comments there.

fastlane is now a mono repo, you can read more about the change in our blog post. All tools are now available in the fastlane main repo 🚀

@fastlane-old fastlane-old locked and limited conversation to collaborators Mar 11, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

5 participants