-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deliver fails with "Unexpected Error" after uploading package to iTunes Connect #6455
Comments
Just started seeing the same error as well, starting yesterday. We were able to deploy some 20 apps with no issue Thursday afternoon, with submission for review and everything. Thursday night/Friday morning, we were able to upload but started getting Unexpected Errors on submission for review. Starting in the afternoon, we were seeing the same error as yours upon upload. Just verified, and it's still there. Relevant portion of our stack trace (seeing this both in Jenkins and on a local release):
|
Same here, exact stack trace. Edit: |
Having the same issue as @nmonasterio. The stack trace looks exactly the same:
|
Interesting, @dbalas . So, modifying your submission info hash did the trick? Right now I have I'll add these two and see if that makes any difference and report back...
Thanks! |
@dbalas I used to have submission_information({
add_id_info_uses_idfa: false,
export_compliance_uses_encryption: false,
export_compliance_encryption_updated: false,
content_rights_contains_third_party_content: false
}) I noticed that I should only keep one of the two Even if the previous settings have been working for a long time, it seems now something changed. |
@kmpnz Did this just start happening to you (i.e., was your If that's the case that some parameters are now required, I might be able to put in a PR for this, @KrauseFx , so that we fill in any defaults when they're not passed. How does that sound? |
@igorstimoli That did it. Nice work! Let me know if you'd like a PR for that, then, @KrauseFx / @TKBurner . Happy to handle. |
A PR sounds good, thanks @nmonasterio |
Hi All, I'm not sure that's the issue. I have just deployed three apps to the App Store, all updates and one of the apps was successful the other 2 failed, with the same error above, after upload. It fails exactly after upload and well before the Submission Information is triggered.
|
I think @gregk8288 is right Then I logged in iTunesConnect and the app was there, but the build was not processed yet, so at the point it failed it was certainly not ready for triggering the submission information |
Agreed. We had submissions fail throughout the day yesterday. Same issue as everyone is experiencing. For what it's worth, I think iTunes Connect might be having some issues itself. I was greeted with all sorts of 500 errors yesterday in the UI as well, and people are reporting that they have uploaded binaries through Application Loader only to find the .ipa disappear a few minutes later. (Will add link shortly.) I'm going to try looking at some of the HTTP traffic when calling these methods through N Sent from my Nintendo Gameboy
|
Looks like this issue is connected to 500 error on iTC. I can't update any app while I'm getting 500 on iTC. Fastlane can give {"data"=>nil, "messages"=>{"warn"=>nil, "error"=>["Unexpected Error"], "info"=>nil}, "statusCode"=>"ERROR"} on any step (produce, deliver). Also the strangest thing is when I upload binary only ( without app icon) all is working as expected. But as soon as icon uploaded to iTC it gives 500 |
I'm receiving the same errors as well for each app I try and update. |
@Wojcik I was able to replicate the issue with the icon vs. no-icon upload. Good find! |
@igorstimoli @nmonasterio @kd8ssq @Wojcik Just wanted to let you know I reached out to the core team about this and we'll update on this thread. Is this related only to submission_info? |
@TKBurner As said before, I've noticed that the failure occurs before the build is processed, so it seems that the submission_info are not processed yet at that point. When the submit process works the output looks like
But it is failing like this
So we get an unexpected error just after the ipa is uploaded and before it is processed by iTunesConnect |
For context, I've been looking at the payloads for uploading the app icon. Things seem to be pretty consistent, but comparing against the upload_file method here:
|
I'm getting the same 500 Inernal Server Error on iTC as cdunkel above. Also although I started having the same problem everyone else described here I'm getting it immediately after a successful login to iTC when using fastlane now. |
@cdunkel @365SplendidSuns Saw those yesterday, too. |
@cdunkel @365SplendidSuns Do you think this new issue is on Apple's side? It seems to be but I wanted to check with you. Either way we are looking into this. 👍 👍 💯 |
@TKBurner I'd be surprised if it wasn't Apple's side to be honest. Since my last post I've actually had one app submitted fine using deliver and another which failed after successfully selecting build with the error message "You must upload a large app icon" (My icons were fine). |
@TKBurner It would seem so, especially given the fact that the payload currently being generated is just about identical. Do we have any insight on what the validation is (i.e., it might have changed)? |
It seems that it is ITC. I've had several times today where I've received 500 errors when I try to manage some of my apps. I've also had trouble logging in and navigating around their interface. Sometimes I receive a generic error message, other times I receive a 500 error message. |
@TKBurner it definitely seems like Apple is a big part of it. The only thing that I'm seeing that might not be Apple's fault is that if I'm doing back-to-back releases I can only make it through one run before I see this issue. Re-running Fastlane then gets me through another app release. That said, I've been seeing the same behavior as @kd8ssq. iTC seems so unstable today that I'm amazed I'm getting anything through. |
Same thing here, error signature looks the same and occurs randomly. Apple is preparing its 2017 April fools prank in advance. |
@GandjaFuzz @kmpnz @cdunkel @kd8ssq @365SplendidSuns @nmonasterio Any new findings? The team is looking into this! 👍 👍 👍 |
I've found that everything seems to upload properly (screenshots, metadata and the binary), but as soon as it gets to the step where it's supposed to wait for the binary check to be complete, it fails. The binary has still uploaded and after a few minutes I'll get an email that the processing is complete. If I try to login to ITC around the time of the error, I'll get a 500 error when I click "My Apps". After a few minutes I can view all the apps but I still get an error "We cannot process your request" if I try to view the newly uploaded app. If I let it sit for about 20 minutes then I can get into the app and manually mark it for review and everything works. |
@TKBurner My observations so far: Screenshots and the metadata are getting uploaded. The Transporter kicks in and according to the logs the binary should be uploaded as well, but I can't find in itunesconnect afterwards, even after a while. Here is a log snippet:
|
Just this morning I've noticed when I try to create a new app in ITC using produce, it takes a very long time to create. Most of the time my script times out, then I have to wait till I see the app created in ITC before I can continue.
|
still having the same issue. +-------------------------------------------------------------+------------------------------------+
| deliver 1.14.2 Summary |
+-------------------------------------------------------------+------------------------------------+
| force | true |
| submit_for_review | true |
| automatic_release | true |
| metadata_path | ./fastlane/metadata |
| screenshots_path | ./calabash_screenshots |
| app_icon | ./fastlane/../Framework/Resourc... |
| app_version | 1.5 |
| release_notes.default | Bug fixes. General stability up... |
| app_review_information.first_name | xxxxxxxx |
| app_review_information.last_name | xxxxxxxx |
| app_review_information.phone_number | xxxxxxxx |
| app_review_information.email_address | xxxxxxxx |
| price_tier | 0 |
| copyright | xxxxxxxx |
| app_rating_config_path | ./fastlane/./ratings.json |
| submission_information.add_id_info_uses_idfa | true |
| submission_information.add_id_info_serves_ads | true |
| submission_information.add_id_info_limits_tracking | true |
| submission_information.add_id_info_tracks_action | false |
| submission_information.add_id_info_tracks_install | false |
| submission_information.export_compliance_encryption_updated | false |
| ipa | /Users/Shared/Jenkins/Home/work... |
| username | xxxxxxxx |
| app_identifier | xxxxxxxx |
| skip_binary_upload | false |
| skip_screenshots | false |
| skip_metadata | false |
| dev_portal_team_name | xxxxxxxx |
+-------------------------------------------------------------+------------------------------------+
[09:53:00]: Successfully uploaded screenshots to iTunes Connect
[09:53:02]: Price Tier unchanged (tier 0)
[09:53:03]: Uploading app icon...
[09:53:11]: Uploading binary to iTunes Connect
[09:53:12]: Going to upload updated app to iTunes Connect
[09:53:12]: This might take a few minutes. Please don't interrupt the script.
[09:54:28]: iTunes Transporter successfully finished its job
[09:54:28]: ------------------------------------------------------------------------------------------------------
[09:54:28]: Successfully uploaded package to iTunes Connect. It might take a few minutes until it's visible online.
[09:54:28]: ------------------------------------------------------------------------------------------------------
[09:54:28]: Finished the upload to iTunes Connect
[09:54:29]: Variable Dump:
[09:54:29]: {:PLATFORM_NAME=>nil, :LANE_NAME=>"deploy", :BUILD_NUMBER=>"There does not seem to be a CURRENT_PROJECT_VERSION key set for this project. Add this key to your target's expert build settings.", :PRODUCE_APPLE_ID=>"xxxxxxxx", :CERT_FILE_PATH=>"/Users/Shared/Jenkins/Home/workspace/iOS Build - Complete Release/iOS/CM68X7BFDE.cer", :CERT_CERTIFICATE_ID=>"CM68X7BFDE", :SIGH_PROFILE_PATH=>"/Users/Shared/Jenkins/Home/workspace/iOS Build - Complete Release/iOS/AppStore_com.xxxxxxxx.xxxxxxxx.mobileprovision", :SIGH_PROFILE_PATHS=>["/Users/Shared/Jenkins/Home/workspace/iOS Build - Complete Release/iOS/AppStore_com.xxxxxxxx.xxxxxxxx.mobileprovision"], :SIGH_UDID=>"xxxxxxxx-xxxxxxxx-xxxxxxxx-xxxxxxxx-xxxxxxxx", :SIGH_PROFILE_TYPE=>"app-store", :IPA_OUTPUT_PATH=>"/Users/Shared/Jenkins/Home/workspace/iOS Build - Complete Release/iOS/Framework.ipa", :DSYM_OUTPUT_PATH=>"/Users/Shared/Jenkins/Home/workspace/iOS Build - Complete Release/iOS/Framework.app.dSYM.zip", :XCODEBUILD_ARCHIVE=>"/Users/Shared/Jenkins/Library/Developer/Xcode/Archives/2016-10-14/Framework 2016-10-14 09.49.28.xcarchive"}
[09:54:29]: {"data"=>nil, "messages"=>{"warn"=>nil, "error"=>["Unexpected Error"], "info"=>nil}, "statusCode"=>"ERROR"}
+------+---------------------------------------------------------------+-------------+
| fastlane summary |
+------+---------------------------------------------------------------+-------------+
| Step | Action | Time (in s) |
+------+---------------------------------------------------------------+-------------+
| 1 | Verifying required fastlane version | 0 |
| 2 | team_id | 0 |
| 3 | increment_build_number | 0 |
| 4 | produce | 12 |
| 5 | cert | 60 |
| 6 | sigh | 46 |
| 7 | git -C .. apply fastlane/stopAskLocation.patch | 0 |
| 8 | git -C .. apply -R fastlane/stopAskLocation.patch | 0 |
| 9 | open afp://admin:AIp4ssw0rd@buildservershost.private/Shared | 0 |
| 10 | [ -d /Volumes/Shared/Dropbox\ \(AppInstitute\)/AppInstitute\ | 0 |
| 11 | cp ../AppStore_com.* /Volumes/Shared/Dropbox\ \(AppInstitute\ | 0 |
| 12 | cp ../*.mobileprovision /Volumes/Shared/Dropbox\ \(AppInstitu | 0 |
| 13 | cp production_* /Volumes/Shared/Dropbox\ \(AppInstitute\)/App | 0 |
| 14 | update_project_code_signing | 0 |
| 15 | gym | 99 |
| 💥 | deliver | 204 |
| 17 | echo "[RaiseError/]{"reference": "fastlane_deploy","errorData | 0 |
+------+---------------------------------------------------------------+-------------+
[09:54:29]: fastlane finished with errors |
I've been having the having this same issue the past 2 days. I forgot to save my output, but it's identical to @igorstimoli above. The ipa successfully uploads and then fastlane fails. I also noticed that when I try to view the app in ITC I get a 500 error saying "We can't process your request." After about 30 minutes of waiting it finally stops throwing the error in ITC. Attached the report.xml |
I've been seeing the problem for about as long as @ChrisVolentine. It's nice to know that I'm not alone, haha. Unlike some of the other people in this thread I'm only seeing the error in the Just for reference, this is my output:
|
I put together a ruby script that uses Spaceship to finish submitting an app for review if the deliver fails right after upload as it seems to for most of us.
Then you can It is based on https://github.com/fastlane/fastlane/blob/master/deliver/lib/deliver/submit_for_review.rb but for getting the |
Thanks for this, @zineer ! So, what you're saying is that, even with your existing (We might be able to pull this in with a extra option to retry for x amount of times until it works, too...) |
@nmonasterio Correct. I noticed that (at least in my case) after Deliver failed with "Unexpected Error", logging into iTunesConnect in my browser to view the new app would also throw errors, but within a minute or so I would be able to view the app. Then trying to view the version would throw another error, but it also went away within a couple minutes and I was able to see the build that was delivered was successfully uploaded and was processing. Once the build was finished processing, I was able to select it and submit the app for review. So the script I wrote above basically just handles that process which I was doing manually. I use another custom build script which handles creating Cordova apps for me and calls Fastlane as part of that, so I just have it check the exit code from fastlane and run my script from above when a failure code is found. |
Hi everyone! We are going to hold off on trying to write a fix/workaround for this for the time being as this is something that is happening on Apple's end (given that they are displaying 500's on the web) and we expect them to fix it in the not-so-distant future. In the mean time, we would encourage you to submit issues to iTunesConnect's support center with reports that this happens even when uploading via the web UI. |
For the moment I applied this inelegant change to the SubmitForReview class in deliver/submit_for_review.rb def submit!(options)
app = options[:app]
####### here starts the change #######
# set a timer
start = Time.now
UI.message("Trying to select the build...")
# start a loop to try multiple times
loop do
begin
select_build(options)
# if select_build doesn't return any error break and continue normally
break
rescue
# if select_build fails output a message and retry after 60 secs
UI.message("")
UI.message("Trying again...")
if (Time.now - start) > (60 * 2)
UI.message("#{((Time.now - start) / 60).round} minutes passed...")
end
# if still failing after 20 minutes will abort
if (Time.now - start) > (60 * 20)
UI.message("it's taking too long!")
UI.message("Aborting.")
raise "Error while trying to select the build in iTunesConnect."
end
sleep 60
end
end
####### here ends the change #######
UI.message("Submitting the app for review...")
submission = app.create_submission
# Set app submission information
# Default Values
submission.content_rights_contains_third_party_content = false
submission.content_rights_has_rights = true
submission.add_id_info_uses_idfa = false
# User Values
if options[:submission_information]
options[:submission_information].each do |key, value|
UI.message("Setting '#{key}' to '#{value}'...")
submission.send("#{key}=", value)
end
end
# Finalize app submission
submission.complete!
UI.success("Successfully submitted the app for review!")
end it's based on @zineer script concept, but applied directly to deliver source code @ohwutup waiting for a better solution from your side I want to let you know that trying this with four apps the average waiting time has been 5 minutes before deliver was able to select the build and exit the loop. After that everything worked properly |
ITC returns 500 when uploading an icon and save. The JSON for icon looks like this:
Before Apple made change to ITC, we only need to change The solution is simply provide It should fix #6425 as well. |
@sunboshan Interesting. I did compare the payloads last week and didn't see anything different per se. I hadn't thought about newly required fields. Have you tested passing the extra parameters? If so, what did you base your It should be an easy PR, unless @KrauseFx wants to handle it directly. Good find! |
I did speak to a member of Apple developer support, especially since I was getting 500 errors in the iTC web UI whenever I would try to view my apps immediately after a Fastlane failure. He did confirm that they have been speaking with other developers who were seeing a similar issue, so they were reasonably confident that it was a systemic issue on their end. It does seem to be intermittent, though, so it sounded like they're having trouble tracking it down. If I hear more back from them I'll post it here. |
@nmonasterio the
@KrauseFx already has the fix for screenshot files in #6423, need to do similar fix for icon files. This has been tested for bunch of apps, providing |
Thank you for the insight, @sunboshan . I can confirm that by leaving out the app_icon option from deliver the submission succeeds without any errors. Would be great if this could get fixed. |
Hi @GeovationMax Thanks for following up. I notified the core team that this issue is still present. 👍 |
I've also been seeing the same errors: 500s and "We can't process your request." pages for some of the apps we update/create. I've been submitting for review manually to see if that helps. However, today I'm starting to see newly created apps take exceptionally long to appear on ITC. I've had the counter in |
Hey everyone, thanks for all the reports, and sorry it took so long. Thanks to @sunboshan, it was easy to reproduce the issue and provide a fix. I've just pushed #6652, which we'll merge and release as soon as possible 🚀 We'll update this GitHub issue once the new version is live ✨ |
spaceship 0.36.1 has been shipped which resolves this issue. You can update to it by running: |
deliver 1.14.3 has been released with the fix! 🚀 |
Can confirm it works here.
|
New Issue Checklist
Issue Description
Deliver fails with "Unexpected Error" after uploading package to iTunes Connect
It happened three time with three different apps after the last deliver update (v1.41.1)
Complete output when running fastlane, including the stack trace and command used
Deliverfile:
Environment
Jenkins version 2.7.2
MacOS X version 10.11.3
fastlane version 1.105.0
Do you use bundler to execute fastlane (i.e.
bundle exec fastlane
)?NO
Do you use a Ruby environment manager (e.g.
chruby
,rbenv
,rvm
)?NO
The text was updated successfully, but these errors were encountered: