Spaceship::TunesClient::ITunesConnectError: invalid request body

[summera]

New Issue Checklist

• Updated fastlane to the latest version
• I have read the Contribution Guidelines

Issue Description

Receiving Spaceship::TunesClient::ITunesConnectError: invalid request body when calling Spaceship::Tunes.select_team. The request to set the team id on line 88 is returning HTTP 400. Here is the response body:

{
  "data"=>nil,
  "messages"=>{"warn"=>nil, "error"=>["invalid request body"], "info"=>nil}, 
  "statusCode"=>"ERROR"
}

I did some digging with switching teams in ITC and it looks like Spaceship needs the dsId param in the ra/v1/session/webSession. Once I added this param to the request, I received a 200 and everything worked as expected.

response = request(:post) do |req|
  req.url "ra/v1/session/webSession"
  req.body = { contentProviderId: team_id, dsId: 'mydsid' }.to_json
  req.headers['Content-Type'] = 'application/json'
end

Note: by the time i got this posted there was a duplicate: #6710 . sorry about that

[ldiqual]

@summera I'm sure the fastlane team will react promptly, but in the meantime is there a workaround besides patching the gem?

[summera]

I'm not quite sure what the dsId is yet because I can't even load ITC right now haha. Maybe its the user's ID? So I'm not sure if Spaceship provides a way to obtain this ID already. As far as I can tell this needs to be in the request for it to work now. So immediate fix would be patching.

[chakming]

@summera ITC seems updated, have a new login page layout now

[summera]

@chakming yea ITC was telling me it was down for a few and now login page looks a little different. I think everything else seems to be the same and error still exists though.

dsId is different for each user. If you go to your Personal Details for your account it's the id at the end of that URL... https://itunesconnect.apple.com/WebObjects/iTunesConnect.woa/ra/ng/users_roles/#{dsid}

[chakming]

@summera found one interesting thing: if I use another dsId which is not refer to my user account, it still works

[summera]

Ha. You're right. Just putting a random ID does work. This worked for me:

      response = request(:post) do |req|
        req.url "ra/v1/session/webSession"
        req.body = { contentProviderId: team_id, dsId: '123' }.to_json
        req.headers['Content-Type'] = 'application/json'
      end

[ChrisVolentine]

@summera I added a random dsId to my request body like you have, and it started working again for me as well

[summera]

I found that the actual dsId can be obtained from the user detail request in TunesClient#user_detail_data inside the sessionToken json object. It's just not parsed from the response in the current implementation.

[luskin]

^ worked for me as well!

[KrauseFx]

Hey everyone, thanks for the reports, I can reproduce the issue, I'm working on a fix 🚀

[summera]

@KrauseFx just came up with this:

summera@7f8adc3

I can open PR if you'd like.

[KrauseFx]

Awesome, thank you @summera, I pushed this via #6716. Preparing a new release in a minute

[KrauseFx]

Hey, thanks for your patience everyone, we were able to push new releases for spaceship, pilot and deliver, please update to the latest release using [sudo] gem update deliver or [sudo] gem update pilot. If you're using bundler use bundle update instead 👍

Special thanks to @summera for providing a super fast fix, and @milch for reviewing all the required version bumps and dependency updates 🚀

Please let us know if that solves the issue for you.

[santoshshetty2612]

updated to latest version of deliver and fastlane. Invalid request body error is resolved now.
But getting the following error:

ruby-2.3.0/gems/deliver-1.14.4/lib/deliver/setup.rb:63:in block in generate_metadata_files': [!] undefined method<<' for nil:NilClass (NoMethodError)
from .rvm/gems/ruby-2.3.0/gems/deliver-1.14.4/lib/deliver/setup.rb:57:in `each'

[KrauseFx]

@santoshshetty2612 That's a separate issue, I'll provide a fix in a minute 👍

[nitindhar7]

@KrauseFx thanks for the fast fixes! works perfectly for me :)