Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screengrab: clean status bar #8488

Closed
dral3x opened this issue Mar 10, 2017 · 8 comments
Closed

Screengrab: clean status bar #8488

dral3x opened this issue Mar 10, 2017 · 8 comments

Comments

@dral3x
Copy link
Contributor

dral3x commented Mar 10, 2017

It's not an issue, it's a feature request.

Looking around I found this awesome project for configuring Android status bar that will fit perfectly with screenshots generation
https://github.com/PSPDFKit-labs/QuickDemo

I hope you will think about integrating it in screengrab 👍
Thanks!

@fastlane-bot
Copy link

It seems like you have not included the output of fastlane env

To make it easier for us help you resolve this issue, please update the issue to include the output of fastlane env 👍

@bonyadmitr
Copy link

@dral3x
I think SimulatorStatusMagic is enough for 99% of apps.

@KrauseFx
Copy link
Member

@bonyadmitr that's for iOS apps only, I think @dral3x asks for the Android equivalent of it

@dral3x
Copy link
Contributor Author

dral3x commented Mar 12, 2017

Correct, I was looking for a good option for Android, as @KrauseFx said.

Android 6/7 already has some built-in support in the OS for this DEMO mode, so, in theory, we can integrate that directly inside screengrab (at least I hope!).

@KrauseFx
Copy link
Member

@dral3x We don't currently plan on building something ourselves, however we're more than happy to link to a good solution, similarly to how we do it for iOS apps 👍

@asfalcone
Copy link
Contributor

I made a PR to mention QuickDemo in the screengrab readme. #8739

@FlorianRauscha
Copy link

@dral3x I've made a demo mode plugin (https://github.com/FlorianRauscha/fastlane-plugin-demo_mode). Maybe it will help you.

@dral3x
Copy link
Contributor Author

dral3x commented Apr 11, 2017

@FlorianRauscha amazing job! I will give it a try in the upcoming weeks. Thank you!

@fastlane fastlane locked and limited conversation to collaborators Jul 10, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants