Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Action to modify services #10010

Merged
merged 4 commits into from
Aug 9, 2017
Merged

Action to modify services #10010

merged 4 commits into from
Aug 9, 2017

Conversation

bhimsenpadalkar
Copy link
Contributor

@bhimsenpadalkar bhimsenpadalkar commented Aug 9, 2017 •
edited

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

This is against the issue raised here

Description

This will add the action to modify the services.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Aug 9, 2017
KrauseFx
KrauseFx reviewed Aug 9, 2017
View reviewed changes
fastlane/lib/fastlane/actions/modify_services.rb
UI.user_error!("The key: '#{key}' is not supported in `enable_services' - following keys are available: [#{allowed_keys.join(',')}]") unless allowed_keys.include? key.to_sym
end
end),
FastlaneCore::ConfigItem.new(key: :team_id,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'd also need the team name here, like see produce/options.rb 👍

KrauseFx
KrauseFx reviewed Aug 9, 2017
View reviewed changes
fastlane/lib/fastlane/actions/modify_services.rb Outdated
end

def self.author
"Bhimsen Padalkar"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use your Twitter or GitHub username 👍

KrauseFx
KrauseFx reviewed Aug 9, 2017
View reviewed changes
fastlane/lib/fastlane/actions/modify_services.rb Outdated
def self.example_code
[
'modify_services(
username: "bhimsenp@thoughtworks.com",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you work at thoughtworks? Do you want to use a dummy email address instead?

@KrauseFx
Copy link
Member

KrauseFx commented Aug 9, 2017

This is great, that's a missing piece to use this produce feature from within fastlane 👍 I added a few comments before it's ready to be merged

@bhimsenpadalkar
Copy link
Contributor Author

Incorporated the feedback

KrauseFx
KrauseFx approved these changes Aug 9, 2017
View reviewed changes
Copy link
Member

@KrauseFx KrauseFx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this is great. One quick question before we merge, have you tried running this action locally? Does it work as expected?

@bhimsenpadalkar
Copy link
Contributor Author

Yes it does.. I checked for few services for "on", "off" and other values (like "complete" for data_protection)

@KrauseFx KrauseFx merged commit 6792033 into fastlane:master Aug 9, 2017
@KrauseFx
Copy link
Member

KrauseFx commented Aug 9, 2017

Awesome, thanks for your contribution 👍

@fastlane-bot
Copy link

Hey @bhimsenpadalkar 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

@KrauseFx KrauseFx mentioned this pull request Aug 10, 2017
Merged
@bhimsenpadalkar bhimsenpadalkar deleted the modify_services branch August 10, 2017 15:46
@bhimsenpadalkar
Copy link
Contributor Author

It doesn't require immediate release. It can go in next release.

@KrauseFx
Copy link
Member

Already live 🚀 Thanks again

@fastlane-bot
Copy link

Congratulations! 🎉 This was released as part of fastlane 2.53.0 🚀

@fastlane fastlane locked and limited conversation to collaborators Oct 10, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@KrauseFx KrauseFx KrauseFx approved these changes

Assignees
No one assigned
Labels
cla: yes status: released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bhimsenpadalkar @googlebot @KrauseFx @fastlane-bot