Add chomp in the deliver metadata upload #10021
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validMotivation and Context
I found a problem that when
fastlane deliver download_metadata
andfastlane deliver run
are repeated, a newline (\n
) added many times toreview_information/*.txt
.Why the problem occurred:
deliver download_metadata
will save the downloaded each values with end of new line.deliver run
will upload to iTC values that read from the file andstrip
orchomp
.chomp
value for the review information process.Description
Added the
chomp
in the metadata upload process.