Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add chomp in the deliver metadata upload #10021

Conversation

fujikky
Copy link
Contributor

@fujikky fujikky commented Aug 10, 2017

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

I found a problem that when fastlane deliver download_metadata and fastlane deliver run are repeated, a newline (\n) added many times to review_information/*.txt.

Why the problem occurred:

  1. deliver download_metadata will save the downloaded each values with end of new line.
  2. deliver run will upload to iTC values that read from the file and strip or chomp.
  3. But, deliver does not contains chomp value for the review information process.

Description

Added the chomp in the metadata upload process.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@fujikky
Copy link
Contributor Author

fujikky commented Aug 10, 2017

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

Copy link
Member

@KrauseFx KrauseFx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @fujikky, welcome to the fastlane community, and thanks for your contribution, this is great 🚀

@KrauseFx KrauseFx merged commit 99cbeae into fastlane:master Aug 10, 2017
@fujikky fujikky deleted the fix-deliver-upload-metadata-review-information branch August 10, 2017 15:33
@fastlane-bot
Copy link

Congratulations! 🎉 This was released as part of fastlane 2.53.0 🚀

@fastlane fastlane locked and limited conversation to collaborators Oct 10, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants