-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix download_dsyms.rb ‘latest’ #10337
Conversation
When `version` is set to `latest`, the following changes apply • choose the edit version before the live version, since the edit version will be newer • nil out `version` since `AppVersion.version` will not necessarily match any version in a `BuildTrain` • return immediately if a `build_number` is found, since there will only be one dSYM for a given build number Closes fastlane#10255
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
• replace a `return` with a `break` • extract method `write_dsym` to reduce complexity
I signed it! |
CLAs look good, thanks! |
I'm unable to run rspec tests due to issue #9177 |
version = latest_version.version | ||
# Try to grab the edit version first, else fallback to live version | ||
latest_version = app.edit_version(platform: platform) || app.live_version(platform: platform) | ||
version = nil |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason for setting this to nil?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the reason is in my commit message:
nil out version since AppVersion.version will not necessarily match any version in a BuildTrain
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just in case that's not clear, if I understand correctly, AppVersion.version corresponds with the version number set in iTunes Connect, which is user settable and does not have to match the version number in the IPA. For example, for necessary but irrelevant reasons, our versions are 6.12 and 1006.12.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @humblehacker !! Welcome to the fastlane community 🚀 !
Congratulations! 🎉 This was released as part of fastlane 2.57.0 🚀 |
When
version
is set tolatest
, the following changes apply• choose the edit version before the live version, since the edit version will be newer
• nil out
version
sinceAppVersion.version
will not necessarily match any version in aBuildTrain
• return immediately if a
build_number
is found, since there will only be one dSYM for a given build numberCloses #10255
Checklist
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validMotivation and Context
Description