New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated xcodeproj version to handle variable substitution on bundle id #10853
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
CLAs look good, thanks! |
I discussed about this with @joshdholtz quite some time ago on Slack. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Hey @dral3x 👋 Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉 Please let us know if this change requires an immediate release by adding a comment here 👍 |
Congratulations! 🎉 This was released as part of fastlane 2.64.1 🚀 |
Checklist
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validMotivation and Context
What's happening when you have a project variable inside the bundle id? gym generates the export options plist this way
But then xcrun fails since the bundle id does not find a match inside the plist.
The workaround for this was to passing to gym, inside
export_options
, the plain bundle id of the appThe result with the workaround in place was the following
The real fix is to update
xcodeproj
dependency to version 1.5.2+, where the variable substitution was addressed and fixed.https://github.com/CocoaPods/Xcodeproj/releases/tag/1.5.2
Here the result after updating
xcodeproj
and removing the workaroundDescription
Just changed the dependency version of
xcodeproj
to be, at least 1.5.2