[Spaceship] Ability to use existing IAP screenshots

[ecornbower]

Checklist

• I've run bundle exec rspec from the root directory to see all new and existing tests pass
• I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
• I've read the Contribution Guidelines
• I've updated the documentation if necessary.

Motivation and Context

Fixes issues #9826, #9630 and possibly #10743.

The current code does not allow editing an iOS IAPs (in-app purchases) without uploading a new screenshot as well. This change uses the existing uploaded screenshots by default unless the user specifies that they wish to upload a new one.

This can be tested by retrieving an existing IAP and immediately re-saving it. The current code will fail with an OPERATION_FAILED response due to the missing screenshots and a bug with the contentHosting variable missing. The new code fixes this bug.

app = Spaceship::Application.find("XXX")
iap = app.in_app_purchases.all.first.edit
iap.save!

Description

I've added a public accessor review_screenshot to allow users to retrieve the previously uploaded screenshot data. The new code now re-uses the retrieved values for the review screenshot by default, as well as reuses the existing contentHosting values which were previously missing when editing and causing saving errors.

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
• In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

[ecornbower]

@googlebot I signed it!

[googlebot]

CLAs look good, thanks!

[ecornbower]

Looks like some sort of environment error on CircleCI caused the build to fail, will need an admin to try and rebuild it.

Unexpected environment preparation error: error establishing an SSH session ssh: handshake failed: ssh: unable to authenticate, attempted methods [none publickey], no supported methods remain

[taquitos]

Looks like circleci is having issues today

[ohayon]

📸

[fastlane-bot]

Congratulations! 🎉 This was released as part of fastlane 2.68.1 🚀