Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Appium] Support appium android #11063

Merged
merged 2 commits into from Nov 30, 2017
Merged

[Appium] Support appium android #11063

merged 2 commits into from Nov 30, 2017

Conversation

YusukeHosonuma
Copy link
Contributor

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

Support the following newly.

  • You can also use Appium action on Android. (with no warning)
  • The appium_lib parameter can now be specified.

How to testing.

We prepared a repository for operation confirmation that use Appium via Fastlane.
https://github.com/YusukeHosonuma/AndroidAppiumViaFastlane

  1. Clone repository. (git clone https://github.com/YusukeHosonuma/AndroidAppiumViaFastlane)
  2. exec: bundle install (needs bundler)
  3. exec: ./gradlew build
  4. Launch android emulator. (needs android sdk)
  5. exec: bundle exec fastlane appium_test (needs appium)
  6. Please confirm that you succeed.

Description

  • add android platform to is_supported
  • add parameter :appium_lib to available_options

Copy link
Member

@KrauseFx KrauseFx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great, thanks for your contribution @YusukeHosonuma 👍

@KrauseFx KrauseFx merged commit dd68e47 into fastlane:master Nov 30, 2017
@fastlane-bot
Copy link

Hey @YusukeHosonuma 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

@fastlane-bot
Copy link

Congratulations! 🎉 This was released as part of fastlane 2.68.1 🚀

@YusukeHosonuma YusukeHosonuma deleted the support-appium-android branch December 8, 2017 00:15
@fastlane fastlane locked and limited conversation to collaborators Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants