Limit testing of Timeout-Process-Bug to macOS only #11178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orms (Background: #1504)
KrauseFx
reviewed
Dec 11, 2017
| @@ -430,18 +430,20 @@ def count_processes(text) | |||
| text = "FOOBAR" # random text | |||
| count = count_processes(text) | |||
| cmd = "ruby -e 'sleep 3; puts \"#{text}\"'" | |||
| # this doesn't work | |||
There was a problem hiding this comment.
What a great comment we had in here, haha
KrauseFx
approved these changes
Dec 11, 2017
|
Hey @janpio 👋 Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉 Please let us know if this change requires an immediate release by adding a comment here 👍 |
|
Congratulations! 🎉 This was released as part of fastlane 2.69.0 🚀 |
fastlane-bot
added
status: released
and removed
status: included-in-next-release
labels
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
disable unkilled-process-after-timeout-tests for non-macOS platforms.
this was causing tests to fail on other platforms/environments, where this bug does not exist.
(Background: #1504)