Update swift Fastfile to new core action names #11194
Conversation
| // Build your app - more options available | ||
| gym([[SCHEME]]) | ||
| pilot(username: appleID) | ||
| // sync_code_signing(gitUrl: "gitUrl", appIdentifier: [appIdentifier], username: appleID) |
There was a problem hiding this comment.
Commented out sync_code_signing (aka match) to match the Ruby Fastfile template. If this is in error, I'm happy to revert!
There was a problem hiding this comment.
need to update the code that substitutes these values in fastlane during initialization [SCHEME]
There was a problem hiding this comment.
I'm not sure I follow. The code doesn't match on the action name, so I'd assume there would be no changes to be made there?
There was a problem hiding this comment.
We look for these tokens during initialization and substitute values, check out https://github.com/fastlane/fastlane/blob/master/fastlane/lib/fastlane/setup/setup_ios.rb#L301
That way, when you get the fastfile back, it has all the correct values filled in that were specified during init.
There was a problem hiding this comment.
Ok, ignore me, I took a closer look and you're got it 💯 correct.
| @@ -30,7 +30,7 @@ platform :ios do | |||
| desc "Submit a new Beta Build to Apple TestFlight" | |||
| desc "This will also make sure the profile is up to date" | |||
| lane :beta do | |||
| # match(type: "appstore") # more information: https://codesigning.guide | |||
| # sync_code_signing(type: "appstore") # more information: https://codesigning.guide | |||
There was a problem hiding this comment.
Whoops missed this one before!
| @@ -42,7 +42,7 @@ platform :ios do | |||
| lane :release do | |||
| # sync_code_signing(type: "appstore") | |||
| capture_screenshots | |||
| build_app[[SCHEME]] # Build your app - more options available | |||
| build_app[[SCHEME]] # more options available | |||
There was a problem hiding this comment.
build_app # build your app 👈 worst comment ever!
mpirri
deleted the
update-fastfile-dot-swift-to-new-core-action-names
branch
|
Congratulations! 🎉 This was released as part of fastlane 2.69.1 🚀 |
Checklist
bundle exec rspecfrom the root directory to see all new and existing tests passbundle exec rubocop -ato ensure the code style is validMotivation and Context
We have recently renamed the core fastlane actions and updated Fastfile templates to use those new names. This PR update the Swift Fastfile template to also use the same names.