Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change sync_code_signing example to use an array type #11195

Merged
merged 1 commit into from
Dec 12, 2017

Conversation

mpirri
Copy link
Contributor

@mpirri mpirri commented Dec 12, 2017

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Because the sync_code_signing exports the support ConfigItem types from the match tool, app_identifier is expected to be an Array. To prevent docs build from failing, change the sample code to use an array.

@mpirri mpirri merged commit 6f810ba into master Dec 12, 2017
@mpirri mpirri deleted the fix-sync-code-signing-example branch December 12, 2017 21:31
@fastlane-bot
Copy link

Hey @mpirri 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

@fastlane-bot
Copy link

Congratulations! 🎉 This was released as part of fastlane 2.69.1 🚀

@fastlane fastlane locked and limited conversation to collaborators Feb 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants