Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spaceship and deliver: add support for the 10.5" iPad #11330

Merged
merged 3 commits into from
Jan 8, 2018
Merged

spaceship and deliver: add support for the 10.5" iPad #11330

merged 3 commits into from
Jan 8, 2018

Conversation

KrauseFx
Copy link
Member

@KrauseFx KrauseFx commented Dec 22, 2017 •
edited

Fixes #11267

@KrauseFx
Add support for the new iPad
e09643c 
Fixes #11267

Didn't fully test it yet
@KrauseFx
Copy link
Member Author 

Spaceship::Client::UnexpectedResponse: [!] [IMG_BAD_DIMENSIONS] The image dimensions are not supported. Please adjust to acceptable dimensions and re-save it.

Mh, need to take a closer look into this

@KrauseFx KrauseFx changed the title Add support for the new iPad spaceship and deliver: add support for the new iPad Dec 22, 2017
@KrauseFx
Copy link
Member Author

Alright, pushed and can confirm it works now 👍

@milch
Copy link
Collaborator

milch commented Jan 8, 2018

Maybe rebase first?

@KrauseFx
Copy link
Member Author

KrauseFx commented Jan 8, 2018

Why? What? :)

@KrauseFx KrauseFx merged commit a691c08 into master Jan 8, 2018
@KrauseFx KrauseFx deleted the new-ipad branch January 8, 2018 23:16
@KrauseFx KrauseFx mentioned this pull request Jan 9, 2018
Merged
@fastlane-bot
Copy link

Hey @KrauseFx 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

@NateZ7 NateZ7 mentioned this pull request Jan 9, 2018
Closed
4 tasks
@funnel20
Copy link
Contributor

funnel20 commented Jan 9, 2018

I just saw this title in the Release Notes of 2.75.0.
I was thinking "what, is there a new iPad???".

Apparently that depends on the definition of "new". While looking at the commits, it appears to be referring to the iPad 10.5" display size, as released by Apple in June 2017.

Can you please change this issue's title to:
"spaceship and deliver: add support for the 10.5" iPad"

@KrauseFx KrauseFx changed the title spaceship and deliver: add support for the new iPad spaceship and deliver: add support for the 10.5" iPad Jan 9, 2018
@KrauseFx
Copy link
Member Author

KrauseFx commented Jan 9, 2018

Done @funnel20, sorry you had to look into it :)

@funnel20
Copy link
Contributor

funnel20 commented Jan 9, 2018

@KrauseFx No need to apologise.
I'm just happy I didn't miss an Apple announcement while failing to update my apps 😃

@KrauseFx
Copy link
Member Author

KrauseFx commented Jan 9, 2018

Hehe, makes sense :)

@fastlane-bot
Copy link

Congratulations! 🎉 This was released as part of fastlane 2.75.0 🚀

@fastlane fastlane locked and limited conversation to collaborators Mar 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@milch milch milch approved these changes

Assignees
No one assigned
Labels
cla: yes status: released tool: deliver tool: spaceship
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@KrauseFx @milch @fastlane-bot @funnel20 @janpio @googlebot