Complete rewrite of the fastlane init onboarding flow
#11386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
KrauseFx
commented
Jan 1, 2018
•
KrauseFx
commented
Generated by 🚫 Danger |
…ion of various CocoaPods features
…dd information about how to use it
…dd information about how to use it
…re app doesn't exist, fix order of parameters, skip metadata question when app isn't available
KrauseFx
changed the title
fastlane init onboarding flowfastlane init onboarding flow
lacostej
reviewed
Jan 5, 2018
fastlane/lib/fastlane/setup/setup.rb
Outdated
| UI.error("No iOS or Android projects found in current directory '#{Dir.pwd}'") | ||
| UI.error("Make sure to `cd` into a directory containing your iOS or Android app") | ||
| if UI.confirm("Do you still want to setup a manual fastlane config in the current directory?") | ||
| SetupIos.new( |
There was a problem hiding this comment.
you could ask whether the user wants to setup ios or android by default. Right?
There was a problem hiding this comment.
Ah nice catch, will update. Just waiting for the language checks by @taquitos 👍
lacostej
reviewed
Jan 5, 2018
| UI.success('To not re-enter your packagename and issuer every time you run one of the fastlane tools or fastlane, these will be stored in a so-called Appfile.') | ||
| def fetch_information_for_appfile | ||
| UI.message('') | ||
| UI.message('To not re-enter your packagename and issuer every time you run one of fastlane, these will be stored in a so-called Appfile.') |
There was a problem hiding this comment.
"every time you run one of fastlane"
->
"everytime you run fastlane" ?
taquitos
reviewed
Jan 8, 2018
| @@ -1,8 +1,7 @@ | |||
| var appIdentifier: String { return "[[APP_IDENTIFIER]]" } // The bundle identifier of your app | |||
| var appleID: String { return "[[APPLE_ID]]" } // Your Apple email address | |||
|
|
|||
| var teamID: String { return "[[DEV_PORTAL_TEAM_ID]]" } // Developer Portal Team ID | |||
| var itcTeam: String? { return [[ITC_TEAM]] } // iTunes Connect Team ID (may be nil if no team) | |||
| [[TEAMS]] | |||
There was a problem hiding this comment.
This gets replaced during onboarding, as [[TEAMS]] is the placeholder
taquitos
reviewed
Jan 8, 2018
| end | ||
|
|
||
| def finish_up | ||
| write_fastfile! |
taquitos
reviewed
Jan 9, 2018
fastlane/lib/fastlane/setup/setup.rb
Outdated
| platform = :ios | ||
| elsif is_android? | ||
| # this is used by e.g. configuration.rb to not show warnings when running produce | ||
| ENV["FASTLANE_ONBOARDING_IN_PROCESS"] = 1.to_s |
There was a problem hiding this comment.
global variables are the best
# Conflicts: # credentials_manager/lib/credentials_manager/account_manager.rb # fastlane/lib/fastlane/commands_generator.rb # fastlane/lib/fastlane/setup/setup_android.rb # fastlane/lib/fastlane/setup/setup_ios.rb # fastlane/spec/setup_spec.rb # snapshot/lib/snapshot/setup.rb # spaceship/lib/spaceship/portal/ui/select_team.rb # spaceship/lib/spaceship/tunes/tunes_client.rb
hjanuschka
approved these changes
Jan 9, 2018
4 tasks
|
Congratulations! 🎉 This was released as part of fastlane 2.75.0 🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.