Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert 'Updated handling of Arrays that are passed as Strings' #11424

Merged
merged 1 commit into from
Jan 4, 2018

Conversation

KrauseFx
Copy link
Member

@KrauseFx KrauseFx commented Jan 4, 2018

I'm not sure if we want to revert this, it's your call @taquitos. Just wanted to have a PR ready so we can hit the merge button if we decide to revert

I'm not sure if we want to revert this, it's your call @taquitos. Just wanted to have a PR ready so we can hit the merge button if we decide to revert
Copy link
Collaborator

@taquitos taquitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, better to keep things simple if an easier fix is available! ☂️🐐

@taquitos taquitos merged commit fce4740 into master Jan 4, 2018
@taquitos taquitos deleted the revert-pr1 branch January 4, 2018 16:34
@fastlane-bot
Copy link

Hey @KrauseFx 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

@fastlane fastlane locked and limited conversation to collaborators Mar 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants