Rename shield_io_timeout to shield_service_timeout

[JrGoodle]

Checklist

• I've run bundle exec rspec from the root directory to see all new and existing tests pass
• I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
• I've read the Contribution Guidelines
• I've updated the documentation if necessary.

Motivation and Context

This commit changed the name of this parameter: HazAT/badge@cdf190d

Our CI at work failed to run fastlane because the parameter name change caused an error.

Could not find option 'shield_io_timeout' in the list of available options: dark, alpha, alpha_channel, custom, no_badge, badge_gravity, shield, shield_service_timeout, shield_geometry, shield_gravity, shield_scale, shield_no_resize

After making the changes here and this associated change the build was able to get past the previous error. However now I'm running into a different error when trying to run scan or gym:

uninitialized constant FastlaneCore::PTY::Actions

I'm not sure if this is because of how I'm loading the forked fastlane and plug-in repos, or if it's an actual issue.

Description

This updates the name from shield_io_timeout to shield_service_timeout to match

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
• If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot. The email used to register you as an authorized contributor must be the email used for the Git commit.
• In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

[JrGoodle]

I signed it!

[googlebot]

CLAs look good, thanks!

[JrGoodle]

The contents of the Gemfile I'm using to test:

# Autogenerated by fastlane
#
# Ensure this file is checked in to source control!

source "https://rubygems.org"

gemspec path: File.expand_path("/Users/jenkins/fastlane")

plugins_path = File.join(File.dirname(__FILE__), 'fastlane', 'Pluginfile')
eval_gemfile(plugins_path) if File.exist?(plugins_path)

gem 'xcpretty'

And the contents of fastlane/Pluginfile:

# Autogenerated by fastlane
#
# Ensure this file is checked in to source control!

gem 'fastlane-plugin-badge', path: "/Users/jenkins/fastlane-plugin-badge"

[KrauseFx]

Thanks for the PR, really appreciated. This shouldn't have happened, and this PR will also break all fastlane setups using that parameter, I'll reach out to the package author 👍

[JrGoodle]

@KrauseFx so should I go ahead and close this PR?

[KrauseFx]

Seems like it's resolved as soon as a new version by Daniel is pushed 👍