Improve behavior of cfpropertylist extension

[jdee]

Checklist

• I've run bundle exec rspec from the root directory to see all new and existing tests pass
• I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
• I've read the Contribution Guidelines
• I've updated the documentation if necessary.

Motivation and Context

This extension sometimes causes problems when used with RVM gemsets.

Description

Be careful about removing the #to_plist method in case it was already removed.

[jdee]

@milch @KrauseFx @snatchev Lost my Slack. I think this might help.

[milch]

Yeah Slack is dead I think. Looks like you're checking whether :remove_method exists rather than :to_plist though?

[KrauseFx]

🚀

[KrauseFx]

Do we also need the begin rescue blocks here?

[KrauseFx]

Similar to a879476 I mean

[jdee]

Even that doesn't actually fix the problem, which I can still produce. It raises at line 17, despite the check for the existence of the method.

[jdee]

That works when rescuing NameError. But I really have no idea why it's happening.

I also still see this:

[⠋] 🚀 /Users/jdee/.rvm/rubies/ruby-2.4.2/lib/ruby/gems/2.4.0/gems/tty-screen-0.6.4/lib/tty/version.rb:3: warning: already initialized constant TTY::Screen::VERSION
/Users/jdee/.rvm/gems/ruby-2.4.2@global/gems/tty-screen-0.6.4/lib/tty/version.rb:3: warning: previous definition of VERSION was here
[⠦] 🚀 /Users/jdee/.rvm/gems/ruby-2.4.2@global/gems/fastlane-2.75.1/spaceship/lib/spaceship/test_flight/build.rb:87: warning: already initialized constant Spaceship::TestFlight::Build::BUILD_STATES
/Users/jdee/.rvm/rubies/ruby-2.4.2/lib/ruby/gems/2.4.0/gems/fastlane-2.75.1/spaceship/lib/spaceship/test_flight/build.rb:87: warning: previous definition of BUILD_STATES was here
[✔] 🚀 

But this seems to fix the crash.

[janpio]

@jdee Is this good to merge in your opinion?

[bguest]

Can we get this merged in, I'm sick of copying this code into my local gem everytime it brakes, seems like a no brainer...

[fastlane-bot]

Hey @jdee 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

[fastlane-bot]

Congratulations! 🎉 This was released as part of fastlane 2.90.0 🚀