Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused init classes #11601

Merged
merged 1 commit into from
Mar 8, 2018
Merged

Remove unused init classes #11601

merged 1 commit into from
Mar 8, 2018

Conversation

KrauseFx
Copy link
Member

No description provided.

@fastlane-bot-helper
Copy link
Contributor

fastlane-bot-helper commented Jan 17, 2018 •
edited

2 Warnings
⚠️ Big PR
⚠️ Please provide a changelog summary in the Pull Request description @KrauseFx

Generated by 🚫 Danger

lacostej
lacostej approved these changes Jan 17, 2018
View reviewed changes
Copy link
Collaborator

@lacostej lacostej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cleanup is good.

There's 0 risk of someone wanted to use this code from the ruby gem right?

@KrauseFx KrauseFx requested a review from taquitos March 5, 2018 19:03
@joshdholtz joshdholtz merged commit 9299846 into master Mar 8, 2018
@joshdholtz joshdholtz deleted the remove-unused-classes branch March 8, 2018 16:39
@joshdholtz joshdholtz mentioned this pull request Mar 8, 2018
Merged
@fastlane-bot
Copy link

Hey @KrauseFx 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

@fastlane fastlane locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lacostej lacostej lacostej approved these changes

@thii thii thii approved these changes

@taquitos taquitos Awaiting requested review from taquitos

Assignees
No one assigned
Labels
cla: yes status: included-in-next-release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@KrauseFx @fastlane-bot-helper @fastlane-bot @lacostej @thii @joshdholtz @googlebot