Improve error message when specified scheme is not found #12182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since fastlane#12027, schemes are read with Xcodeproj rather than parsed from `xcodebuild -list` output. Unlike `xcodebuild -list`, Xcodeproj reads only **shared** schemes (from [project](https://github.com/CocoaPods/Xcodeproj/blob/50e70d32d1176d14c57807c8b5adaa6f42ef38ac/lib/xcodeproj/project.rb#L780-L793) and also from [workspace](https://github.com/CocoaPods/Xcodeproj/blob/50e70d32d1176d14c57807c8b5adaa6f42ef38ac/lib/xcodeproj/workspace.rb#L199-L204)). As the specified scheme might exist on the user machine but not be shared, the error message is improved to suggest that the scheme must be shared with a link to Apple's documentation.
4 tasks
getaaron
approved these changes
Mar 27, 2018
|
Thanks for the PR, @0xced 👍 |
|
Hey @0xced 👋 Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉 Please let us know if this change requires an immediate release by adding a comment here 👍 |
4 tasks
fastlane-bot
added
status: released
and removed
status: included-in-next-release
labels
|
Congratulations! 🎉 This was released as part of fastlane 2.88.0 🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #12027, schemes are read with Xcodeproj rather than parsed from
xcodebuild -listoutput. Unlikexcodebuild -list, Xcodeproj reads only shared schemes (from projectand also from workspace).
As the specified scheme might exist on the user machine but not be shared, the error message is improved to suggest that the scheme must be shared with a link to Apple's documentation.