[match][spaceship] Fixed matchfile overriding fastfile team_id with bonus spaceship select_team additions

[joshdholtz]

Fixes #12146
Starting implementation of #12234 (see this issue for more details and examples)

Issue

Using action options verify_block can have some unintended side effects that will break the rules of Priorities of parameters and options

1. CLI parameter (e.g. gym --scheme Example) or Fastfile (e.g. gym(scheme: 'Example'))
2. Environment variable (e.g. GYM_SCHEME)
3. Tool specific config file (e.g. Gymfile containing scheme 'Example')
4. Default value (which might be taken from the Appfile, e.g. app_identifier from the Appfile)
5. If this value is required, you'll be asked for it (e.g. you have multiple schemes, you'll be asked for it)

Example of how this happens

This is mainly a problem when load_configuration_file is called outside of standard action loading process -

fastlane/fastlane/lib/fastlane/actions/sync_code_signing.rb

Lines 7 to 16 in 055f325

	class SyncCodeSigningAction < Action
	def self.run(params)
	require 'match'
	params.load_configuration_file("Matchfile")
	Match::Runner.new.run(params)
	define_profile_type(params)
	define_provisioning_profile_mapping(params)
	end

In match's case above, it will load...

1. Load the Fastfile parameter (this is correct)
2. Attempt to load the Matchfile parameter but doesn't because Fastfile parameter set
3. During match's run, this extra load_configuration_file will attempt to load files from Matchfile again (and won't override the Fastfile value) but the verify_block method gets called and sets ENV["FASTLANE_TEAM_ID"] to a potentially different team id (if the Matchfile value is different than the Fastfile value) which will cause a different value to be shown in match's summary than what actually get's used by spaceship

Solution

1. verify_block should not be used to set environment variables verify_block can actually get called multiple times and should really only be used for verifying a value (not setting it)
2. We should stop setting environment variables for FASTLANE_TEAM_ID, FASTLANE_TEAM_NAME, FASTLANE_ITC_TEAM_ID, and FASTLANE_ITC_TEAM_NAME for to use with the spaceship's select_team method
3. select_team should take a parameter for team_id and team_name when explicitly looking for a team instead of setting a global environment variable that may potentially get overridden

[KrauseFx]

Make sure to update the PR title and also update it when hitting that merge button

[KrauseFx]

I haven't tested it, but the code looks 💯

[fastlane-bot]

Hey @joshdholtz 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

[fastlane-bot]

Congratulations! 🎉 This was released as part of fastlane 2.90.0 🚀