Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix force output files on trade_representative_contact_information #12290

Merged
merged 1 commit into from Apr 15, 2018
Merged

Fix force output files on trade_representative_contact_information #12290

merged 1 commit into from Apr 15, 2018

Conversation

mofneko
Copy link
Contributor

@mofneko mofneko commented Apr 12, 2018

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Description

In my case, when creating a new application, iTC had my developer profile entered by default. However, because postal code was not registered in the item of trade_representative_contact_information, only postal_code.txt was not created in the process of deliver init and download_metadata.
If some information is missing like this, the generated file will also become fragmented, so I modified it.

Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this fix! 💪 The other metadata sections behave the same by making an empty file so I think this is the correct way to go for this as well 👍

@joshdholtz joshdholtz merged commit 00d53eb into fastlane:master Apr 15, 2018
@fastlane-bot
Copy link

Hey @mofneko 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

@mofneko
Copy link
Contributor Author

mofneko commented Apr 15, 2018

You’re welcome😊!
I am also pleased to contribute to your great product🍻

@fastlane-bot
Copy link

Congratulations! 🎉 This was released as part of fastlane 2.92.0 🚀

@fastlane fastlane locked and limited conversation to collaborators Jun 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants