Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[swift] give lane_context return_type of hash_with_strings #12313

Merged

Conversation

joshdholtz
Copy link
Member

Fixes #12303

Wut

  • No return type so Swift returned nothing when laneContext was called 馃槉
class Fastfile: LaneFile {
	func testLane() {

		let changelog = changelogFromGitCommits(commitsCount: 1)
		puts(message: "changelog: \(changelog)")

		let dict = laneContext()
		puts(message: "dict: \(dict["FL_CHANGELOG"])")
	}
}

But now we can do something like this ^

Copy link
Collaborator

@taquitos taquitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃幏:goat:

@joshdholtz joshdholtz merged commit 9e07ba0 into master Apr 15, 2018
@joshdholtz joshdholtz deleted the joshdholtz-give-laneContext-return-type-for-swift branch April 15, 2018 23:41
@fastlane-bot
Copy link

Hey @joshdholtz 馃憢

Thank you for your contribution to fastlane and congrats on getting this pull request merged 馃帀
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 馃憤
We'll notify you once we shipped a new release with your changes 馃殌

@fastlane-bot
Copy link

Congratulations! 馃帀 This was released as part of fastlane 2.92.0 馃殌

@fastlane fastlane locked and limited conversation to collaborators Jun 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants