Add parameter code_signing_identity for CODE_SIGN_IDENTITY setting #12326

HarrisHan · 2018-04-17T06:38:05Z

Checklist

I've run bundle exec rspec from the root directory to see all new and existing tests pass
I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
I've read the Contribution Guidelines
I've updated the documentation if necessary.

Motivation and Context

update_project_provisioning(
                xcodeproj: "iOSArchive.xcodeproj",
                profile: "./#{profilename}", # optional if you use sigh
                target_filter: "iOSArchive", # matches name or type of a target
                build_configuration: "Release",
              )

When Release Archive a project with the development export method
The Release XCBuildConfiguration's CODE_SIGN_IDENTITY[sdk=iphoneos*] defualt value is "iPhone Distribution"

This will cause the profile doesn't include distribution signing certificate

The same as the Debug Archive with ad-hoc export method for Debug XCBuildConfiguration's CODE_SIGN_IDENTITY defualt value is iPhone Developer

So I add a parameter for update_project_provisioning to change the CODE_SIGN_IDENTITY in XCBuildConfiguration so that the certificate will be find

update_project_provisioning(
                xcodeproj: "iOSArchive.xcodeproj",
                profile: "./#{profilename}", # optional if you use sigh
                target_filter: "iOSArchive", # matches name or type of a target
                build_configuration: "Release",
                code_signing_identity: "iPhone Developer" # optionally specify the codesigning identity
              )

  gym

I use the changed update_project_provisioning action in my local project It worked well

Description

Add parameter codesigning_identity for action update_project_provisioning which you can set to iPhone Developer or iPhone Distribution according to the demand

googlebot · 2018-04-17T06:38:09Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

HarrisHan · 2018-04-17T07:35:20Z

@googlebot
I signed it!

googlebot · 2018-04-17T07:35:22Z

CLAs look good, thanks!

joshdholtz · 2018-04-23T12:45:46Z

fastlane/lib/fastlane/actions/update_project_provisioning.rb

@@ -148,7 +160,8 @@ def self.example_code
            xcodeproj: "Project.xcodeproj",
            profile: "./watch_app_store.mobileprovision", # optional if you use sigh
            target_filter: ".*WatchKit Extension.*", # matches name or type of a target
-            build_configuration: "Release"
+            build_configuration: "Release",
+            codesigning_identity: "iPhone Development" #specified the codesigning identity


Can you change this to be # optionally specify the codesigning identity

Thanks for ur advice I had update the code

joshdholtz

Few small nit picks 🙃

joshdholtz · 2018-04-23T13:14:48Z

fastlane/lib/fastlane/actions/update_project_provisioning.rb

+              unless build_configuration.build_settings["CODE_SIGN_IDENTITY[sdk=iphoneos*]"].nil?
+                build_configuration.build_settings["CODE_SIGN_IDENTITY[sdk=iphoneos*]"] = codesigning_identity
+              end
+              build_configuration.build_settings["CODE_SIGN_IDENTITY"] = codesigning_identity


Can we change the code in this unless to be...

codesign_build_settings_keys = build_configuration.build_settings.keys.select { |key| key.to_s.match(/CODE_SIGN_IDENTITY.*/) } codesign_build_settings_keys.each do |setting| build_configuration.build_settings[setting] = codesigning_identity end

so that it works with other platforms and not just iOS? Inspired by https://github.com/fastlane/fastlane/blob/master/fastlane/lib/fastlane/actions/automatic_code_signing.rb#L46-L49

joshdholtz · 2018-04-23T13:15:07Z

fastlane/lib/fastlane/actions/update_project_provisioning.rb

@@ -130,7 +138,11 @@ def self.available_options
          FastlaneCore::ConfigItem.new(key: :certificate,
                                       env_name: "FL_PROJECT_PROVISIONING_CERTIFICATE_PATH",
                                       description: "Path to apple root certificate",
-                                       default_value: "/tmp/AppleIncRootCertificate.cer")
+                                       default_value: "/tmp/AppleIncRootCertificate.cer"),
+          FastlaneCore::ConfigItem.new(key: :codesigning_identity,


Can we also change this key to code_signing_identity?

Thanks for ur advice I had update the code

joshdholtz · 2018-05-04T13:39:16Z

@HarrisHan Are you still interested in getting this merged in?

HarrisHan

@joshdholtz Thanks for your advice & I have update the code

HarrisHan · 2018-05-05T04:15:31Z

fastlane/lib/fastlane/actions/update_project_provisioning.rb

+              unless build_configuration.build_settings["CODE_SIGN_IDENTITY[sdk=iphoneos*]"].nil?
+                build_configuration.build_settings["CODE_SIGN_IDENTITY[sdk=iphoneos*]"] = codesigning_identity
+              end
+              build_configuration.build_settings["CODE_SIGN_IDENTITY"] = codesigning_identity


googlebot · 2018-05-06T02:45:27Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

googlebot · 2018-05-06T02:50:54Z

CLAs look good, thanks!

HarrisHan

I have update the code

joshdholtz · 2018-05-17T21:56:42Z

fastlane/lib/fastlane/actions/update_project_provisioning.rb

@@ -63,6 +64,11 @@ def self.run(params)
              next
            end

+            codesign_build_settings_keys = build_configuration.build_settings.keys.select { |key| key.to_s.match(/CODE_SIGN_IDENTITY.*/) }


I think this need to be wrapped in a if code_signing_identity otherwise things will get cleared out if not specified 😬

@joshdholtz Thx 😬 I have update the code

joshdholtz

This looks great! Thanks for the contribution ❤️

fastlane-bot · 2018-05-18T19:30:49Z

Hey @HarrisHan 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

fastlane-bot · 2018-05-22T19:33:07Z

Congratulations! 🎉 This was released as part of fastlane 2.96.0 🚀

Add parameter codesigning_identity for CODE_SIGN_IDENTITY setting

675e1e6

googlebot added the cla: no label Apr 17, 2018

googlebot added cla: yes and removed cla: no labels Apr 17, 2018

Add parameter codesigning_identity for CODE_SIGN_IDENTITY setting

6ad5242

HarrisHan changed the title Add parameter codesigning_identity for rs/harris/Desktop/iOSArchive/2GG7WJDZBH.cer | | CERT_CERTIFICATE_ID | 2GG7WJDZBH | | SIGH_PROFILE_PATH | /Users/ha setting Add parameter codesigning_identity for CODE_SIGN_IDENTITY setting Apr 17, 2018

Fix Style/NonNilCheck & Style/IdenticalConditionalBranches

c211333

joshdholtz requested changes Apr 23, 2018

View reviewed changes

fastlane-bot added the status: needs-attention label May 1, 2018

Change param name & using the better way to adjust other platforms

97743aa

HarrisHan commented May 5, 2018

View reviewed changes

googlebot added cla: no and removed cla: yes labels May 6, 2018

HarrisHan force-pushed the master branch from d39bb0f to 97743aa Compare May 6, 2018 02:50

googlebot added cla: yes and removed cla: no labels May 6, 2018

HarrisHan changed the title ~~Add parameter codesigning_identity for CODE_SIGN_IDENTITY setting~~ Add parameter code_signing_identity for CODE_SIGN_IDENTITY setting May 6, 2018

HarrisHan commented May 15, 2018

View reviewed changes

joshdholtz requested changes May 17, 2018

View reviewed changes

Add if code_signing_identity to avoid cleared out if not specified

1b6f86e

joshdholtz approved these changes May 18, 2018

View reviewed changes

joshdholtz merged commit ab13e6c into fastlane:master May 18, 2018

fastlane-bot added status: included-in-next-release and removed status: needs-attention labels May 18, 2018

This was referenced May 21, 2018

Version bump to 2.96.0 #12572

Closed

Version bump to 2.96.0 #12575

Merged

fastlane-bot added status: released and removed status: included-in-next-release labels May 22, 2018

fastlane locked and limited conversation to collaborators Jul 22, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add parameter code_signing_identity for CODE_SIGN_IDENTITY setting #12326

Add parameter code_signing_identity for CODE_SIGN_IDENTITY setting #12326

HarrisHan commented Apr 17, 2018 •

edited

googlebot commented Apr 17, 2018

HarrisHan commented Apr 17, 2018

googlebot commented Apr 17, 2018

joshdholtz Apr 23, 2018

HarrisHan May 6, 2018

joshdholtz left a comment

joshdholtz Apr 23, 2018

HarrisHan May 5, 2018

joshdholtz Apr 23, 2018

HarrisHan May 6, 2018

joshdholtz commented May 4, 2018

HarrisHan left a comment

HarrisHan May 5, 2018

googlebot commented May 6, 2018

googlebot commented May 6, 2018

HarrisHan left a comment

joshdholtz May 17, 2018

HarrisHan May 18, 2018

joshdholtz left a comment

fastlane-bot commented May 18, 2018

fastlane-bot commented May 22, 2018

Add parameter code_signing_identity for CODE_SIGN_IDENTITY setting #12326

Add parameter code_signing_identity for CODE_SIGN_IDENTITY setting #12326

Conversation

HarrisHan commented Apr 17, 2018 • edited

Checklist

Motivation and Context

Description

googlebot commented Apr 17, 2018

What to do if you already signed the CLA

Individual signers

Corporate signers

HarrisHan commented Apr 17, 2018

googlebot commented Apr 17, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

joshdholtz left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

joshdholtz commented May 4, 2018

HarrisHan left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

googlebot commented May 6, 2018

googlebot commented May 6, 2018

HarrisHan left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

joshdholtz left a comment

Choose a reason for hiding this comment

fastlane-bot commented May 18, 2018

fastlane-bot commented May 22, 2018

HarrisHan commented Apr 17, 2018 •

edited