Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changelog from git commits path option #12429

Merged
merged 5 commits into from May 2, 2018
Merged

Changelog from git commits path option #12429

merged 5 commits into from May 2, 2018

Conversation

RishabhTayal
Copy link
Contributor

fixes #12397

RishabhTayal
RishabhTayal commented May 1, 2018
View reviewed changes
fastlane/lib/fastlane/actions/changelog_from_git_commits.rb Outdated
env_name: 'FL_CHANGELOG_FROM_GIT_COMMITS_PATH',
description: 'Path of the git repository',
optional: true,
default_value: './'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this should be the value for default_value. Can someone suggest what would be the correct value here?

cc: @joshdholtz

@RishabhTayal RishabhTayal mentioned this pull request May 1, 2018
Closed
joshdholtz
joshdholtz approved these changes May 2, 2018
View reviewed changes
Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix 👍

@joshdholtz joshdholtz merged commit 3b48f9d into fastlane:master May 2, 2018
@RishabhTayal
Copy link
Contributor Author

🚀

@fastlane-bot
Copy link

Hey @RishabhTayal 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

@joshdholtz joshdholtz mentioned this pull request May 8, 2018
Merged
@RishabhTayal RishabhTayal deleted the changelog_from_git_commits-path-option branch May 8, 2018 17:32
@fastlane-bot
Copy link

Congratulations! 🎉 This was released as part of fastlane 2.95.0 🚀

@keeshux keeshux mentioned this pull request May 11, 2018
Closed
4 tasks
@fastlane fastlane locked and limited conversation to collaborators Jul 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joshdholtz joshdholtz joshdholtz approved these changes

Assignees
No one assigned
Labels
cla: yes status: released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

changelog_from_git_commits
4 participants
@RishabhTayal @fastlane-bot @joshdholtz @googlebot